Title: [259527] trunk/Source/WebCore
- Revision
- 259527
- Author
- [email protected]
- Date
- 2020-04-03 22:06:20 -0700 (Fri, 03 Apr 2020)
Log Message
Build fix: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
https://bugs.webkit.org/show_bug.cgi?id=209925
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
- Apply macros consistently. Regressed in r259513.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259526 => 259527)
--- trunk/Source/WebCore/ChangeLog 2020-04-04 02:42:10 UTC (rev 259526)
+++ trunk/Source/WebCore/ChangeLog 2020-04-04 05:06:20 UTC (rev 259527)
@@ -1,3 +1,12 @@
+2020-04-03 David Kilzer <[email protected]>
+
+ Build fix: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
+ https://bugs.webkit.org/show_bug.cgi?id=209925
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::elementFromPastNamesMap const):
+ - Apply macros consistently. Regressed in r259513.
+
2020-04-03 Jack Lee <[email protected]>
Protect contentFrame in SubframeLoader::loadOrRedirectSubframe with RefPtr.
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (259526 => 259527)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2020-04-04 02:42:10 UTC (rev 259526)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2020-04-04 05:06:20 UTC (rev 259527)
@@ -764,7 +764,7 @@
return validateInteractively();
}
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
void HTMLFormElement::assertItemCanBeInPastNamesMap(FormNamedItem* item) const
{
ASSERT(item);
@@ -789,7 +789,7 @@
if (!weakElement)
return nullptr;
auto element = makeRefPtr(weakElement.get());
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
assertItemCanBeInPastNamesMap(element->asFormNamedItem());
#endif
return element;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
