Title: [259543] trunk/Source/WebCore
- Revision
- 259543
- Author
- [email protected]
- Date
- 2020-04-04 21:16:19 -0700 (Sat, 04 Apr 2020)
Log Message
Build fix v2: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
https://bugs.webkit.org/show_bug.cgi?id=209925
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
(WebCore::HTMLFormElement::addToPastNamesMap):
- Apply macros consistently. Regressed in r259513 and was
not fixed by r259527.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259542 => 259543)
--- trunk/Source/WebCore/ChangeLog 2020-04-05 03:44:39 UTC (rev 259542)
+++ trunk/Source/WebCore/ChangeLog 2020-04-05 04:16:19 UTC (rev 259543)
@@ -1,3 +1,14 @@
+2020-04-04 David Kilzer <[email protected]>
+
+ Build fix v2: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
+ https://bugs.webkit.org/show_bug.cgi?id=209925
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::elementFromPastNamesMap const):
+ (WebCore::HTMLFormElement::addToPastNamesMap):
+ - Apply macros consistently. Regressed in r259513 and was
+ not fixed by r259527.
+
2020-04-04 Wenson Hsieh <[email protected]>
Add a fourth round of logging to help diagnose <webkit.org/b/209685>
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (259542 => 259543)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2020-04-05 03:44:39 UTC (rev 259542)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2020-04-05 04:16:19 UTC (rev 259543)
@@ -764,7 +764,7 @@
return validateInteractively();
}
-#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
+#if ASSERT_ENABLED
void HTMLFormElement::assertItemCanBeInPastNamesMap(FormNamedItem* item) const
{
ASSERT(item);
@@ -789,7 +789,7 @@
if (!weakElement)
return nullptr;
auto element = makeRefPtr(weakElement.get());
-#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
+#if ASSERT_ENABLED
assertItemCanBeInPastNamesMap(element->asFormNamedItem());
#endif
return element;
@@ -797,7 +797,7 @@
void HTMLFormElement::addToPastNamesMap(FormNamedItem* item, const AtomString& pastName)
{
-#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
+#if ASSERT_ENABLED
assertItemCanBeInPastNamesMap(item);
#endif
if (pastName.isEmpty())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
