Title: [259614] trunk/Source/_javascript_Core
- Revision
- 259614
- Author
- [email protected]
- Date
- 2020-04-06 17:11:24 -0700 (Mon, 06 Apr 2020)
Log Message
REGRESSION: 68000 JSC tests failing.
https://bugs.webkit.org/show_bug.cgi?id=210078
<rdar://problem/61364513>
Reviewed by Yusuke Suzuki.
The missing exception check is in jsc shell's GlobalObject::finishCreation().
Since this is just a debugging tool, and this exception will never be thrown in
practice, I've placated the validator by RELEASE_ASSERT'ing that the exception
will never be thrown.
* jsc.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259613 => 259614)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-07 00:00:04 UTC (rev 259613)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-07 00:11:24 UTC (rev 259614)
@@ -1,3 +1,18 @@
+2020-04-06 Mark Lam <[email protected]>
+
+ REGRESSION: 68000 JSC tests failing.
+ https://bugs.webkit.org/show_bug.cgi?id=210078
+ <rdar://problem/61364513>
+
+ Reviewed by Yusuke Suzuki.
+
+ The missing exception check is in jsc shell's GlobalObject::finishCreation().
+ Since this is just a debugging tool, and this exception will never be thrown in
+ practice, I've placated the validator by RELEASE_ASSERT'ing that the exception
+ will never be thrown.
+
+ * jsc.cpp:
+
2020-04-06 Ross Kirsling <[email protected]>
Update minimum ICU version to 60.2
Modified: trunk/Source/_javascript_Core/jsc.cpp (259613 => 259614)
--- trunk/Source/_javascript_Core/jsc.cpp 2020-04-07 00:00:04 UTC (rev 259613)
+++ trunk/Source/_javascript_Core/jsc.cpp 2020-04-07 00:11:24 UTC (rev 259614)
@@ -486,6 +486,7 @@
protected:
void finishCreation(VM& vm, const Vector<String>& arguments)
{
+ auto catchScope = DECLARE_CATCH_SCOPE(vm);
Base::finishCreation(vm);
addFunction(vm, "debug", functionDebug, 1);
@@ -599,7 +600,8 @@
JSFunction* IsHTMLDDAGetter = JSFunction::create(vm, this, 0, "IsHTMLDDA"_s, functionMakeMasquerader);
dollar->putGetter(this, Identifier::fromString(vm, "IsHTMLDDA"), IsHTMLDDAGetter, static_cast<unsigned>(PropertyAttribute::Accessor));
-
+ catchScope.releaseAssertNoException();
+
JSObject* agent = JSFinalObject::create(vm, plainObjectStructure);
dollar->putDirect(vm, Identifier::fromString(vm, "agent"), agent);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
