Title: [259621] trunk/LayoutTests
Revision
259621
Author
[email protected]
Date
2020-04-06 19:23:22 -0700 (Mon, 06 Apr 2020)

Log Message

[Cocoa] REGRESSION(r254389): fast/text/international/system-language/declarative-language.html is failing
https://bugs.webkit.org/show_bug.cgi?id=208023
<rdar://problem/59461792>

Reviewed by Simon Fraser.

minimizedLanguagesFromLanguages() is supposed to minimize the language list;
that's its whole raison d'ĂȘtre

* fast/text/international/system-language/declarative-language-expected.txt:
* fast/text/international/system-language/declarative-language.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (259620 => 259621)


--- trunk/LayoutTests/ChangeLog	2020-04-07 02:16:48 UTC (rev 259620)
+++ trunk/LayoutTests/ChangeLog	2020-04-07 02:23:22 UTC (rev 259621)
@@ -1,3 +1,18 @@
+2020-04-06  Myles C. Maxfield  <[email protected]>
+
+        [Cocoa] REGRESSION(r254389): fast/text/international/system-language/declarative-language.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=208023
+        <rdar://problem/59461792>
+
+        Reviewed by Simon Fraser.
+
+        minimizedLanguagesFromLanguages() is supposed to minimize the language list;
+        that's its whole raison d'ĂȘtre
+
+        * fast/text/international/system-language/declarative-language-expected.txt:
+        * fast/text/international/system-language/declarative-language.html:
+        * platform/mac/TestExpectations:
+
 2020-04-06  Jack Lee  <[email protected]>
 
         Nullptr crash in WebCore::lastPositionInNode when indenting text node that has user-select:all parent.

Modified: trunk/LayoutTests/fast/text/international/system-language/declarative-language-expected.txt (259620 => 259621)


--- trunk/LayoutTests/fast/text/international/system-language/declarative-language-expected.txt	2020-04-07 02:16:48 UTC (rev 259620)
+++ trunk/LayoutTests/fast/text/international/system-language/declarative-language-expected.txt	2020-04-07 02:23:22 UTC (rev 259621)
@@ -1,6 +1,5 @@
-PASS internals.userPreferredLanguages().length is 2
+PASS internals.userPreferredLanguages().length is 1
 PASS internals.userPreferredLanguages()[0].startsWith('ko') is true
-PASS internals.userPreferredLanguages()[1].startsWith('zh') is true
 PASS internals.userPreferredLanguages().length is 3
 PASS internals.userPreferredLanguages()[0] is "hi"
 PASS internals.userPreferredLanguages()[1] is "jp"

Modified: trunk/LayoutTests/fast/text/international/system-language/declarative-language.html (259620 => 259621)


--- trunk/LayoutTests/fast/text/international/system-language/declarative-language.html	2020-04-07 02:16:48 UTC (rev 259620)
+++ trunk/LayoutTests/fast/text/international/system-language/declarative-language.html	2020-04-07 02:23:22 UTC (rev 259621)
@@ -6,9 +6,10 @@
 <body>
 <script>
 if (window.internals) {
-    shouldBe("internals.userPreferredLanguages().length", "2");
+    // minimizedLanguagesFromLanguages() simplifies the language list.
+    // This is intentional.
+    shouldBe("internals.userPreferredLanguages().length", "1");
     shouldBeTrue("internals.userPreferredLanguages()[0].startsWith('ko')");
-    shouldBeTrue("internals.userPreferredLanguages()[1].startsWith('zh')");
     internals.setUserPreferredLanguages(["hi", "jp", "in"]);
     shouldBe("internals.userPreferredLanguages().length", "3");
     shouldBeEqualToString("internals.userPreferredLanguages()[0]", "hi");

Modified: trunk/LayoutTests/platform/mac/TestExpectations (259620 => 259621)


--- trunk/LayoutTests/platform/mac/TestExpectations	2020-04-07 02:16:48 UTC (rev 259620)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-04-07 02:23:22 UTC (rev 259621)
@@ -1830,6 +1830,7 @@
 
 # The navigator.language tests rely on functionality only available in recent releases of macOS Catalina and onward.
 webkit.org/b/200043 [ Mojave Catalina ] fast/text/international/system-language/navigator-language [ Pass Failure ]
+webkit.org/b/208023 [ Sierra HighSierra Mojave ] fast/text/international/system-language/declarative-language.html [ Failure ]
 
 webkit.org/b/204312 imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual.svg [ Failure Pass ]
 
@@ -1969,4 +1970,4 @@
 
 webkit.org/b/209908 svg/custom/animate-initial-pause-unpause.html [ Pass Timeout ]
 
-webkit.org/b/210046 [ Release ] storage/indexeddb/value-cursor-cycle.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/210046 [ Release ] storage/indexeddb/value-cursor-cycle.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to