Title: [259637] trunk/Source/WebKit
- Revision
- 259637
- Author
- [email protected]
- Date
- 2020-04-07 09:00:52 -0700 (Tue, 07 Apr 2020)
Log Message
VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`
<https://webkit.org/b/210094>
<rdar://problem/60334644>
Reviewed by Chris Dumez.
* Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
- Don't forward-declare WebCore::SharedStringHash as a class
since it is a uint32_t.
* UIProcess/VisitedLinkStore.messages.in:
- Use WebCore::SharedStringHash type for `linkHash` to fix the
type mismatch.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259636 => 259637)
--- trunk/Source/WebKit/ChangeLog 2020-04-07 15:48:08 UTC (rev 259636)
+++ trunk/Source/WebKit/ChangeLog 2020-04-07 16:00:52 UTC (rev 259637)
@@ -1,3 +1,19 @@
+2020-04-07 David Kilzer <[email protected]>
+
+ VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`
+ <https://webkit.org/b/210094>
+ <rdar://problem/60334644>
+
+ Reviewed by Chris Dumez.
+
+ * Scripts/webkit/messages.py:
+ (types_that_cannot_be_forward_declared):
+ - Don't forward-declare WebCore::SharedStringHash as a class
+ since it is a uint32_t.
+ * UIProcess/VisitedLinkStore.messages.in:
+ - Use WebCore::SharedStringHash type for `linkHash` to fix the
+ type mismatch.
+
2020-04-07 Chris Dumez <[email protected]>
Unreviewed, drop bad assertion introduced in r259610.
Modified: trunk/Source/WebKit/Scripts/webkit/messages.py (259636 => 259637)
--- trunk/Source/WebKit/Scripts/webkit/messages.py 2020-04-07 15:48:08 UTC (rev 259636)
+++ trunk/Source/WebKit/Scripts/webkit/messages.py 2020-04-07 16:00:52 UTC (rev 259637)
@@ -222,6 +222,7 @@
'WebCore::ServiceWorkerOrClientData',
'WebCore::ServiceWorkerOrClientIdentifier',
'WebCore::ServiceWorkerRegistrationIdentifier',
+ 'WebCore::SharedStringHash',
'WebCore::SleepDisablerIdentifier',
'WebCore::SWServerConnectionIdentifier',
'WebKit::ActivityStateChangeID',
Modified: trunk/Source/WebKit/UIProcess/VisitedLinkStore.messages.in (259636 => 259637)
--- trunk/Source/WebKit/UIProcess/VisitedLinkStore.messages.in 2020-04-07 15:48:08 UTC (rev 259636)
+++ trunk/Source/WebKit/UIProcess/VisitedLinkStore.messages.in 2020-04-07 16:00:52 UTC (rev 259637)
@@ -21,5 +21,5 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
messages -> VisitedLinkStore {
- AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash)
+ AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, WebCore::SharedStringHash linkHash)
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
