Title: [259643] trunk/Source/WebCore
- Revision
- 259643
- Author
- [email protected]
- Date
- 2020-04-07 09:38:32 -0700 (Tue, 07 Apr 2020)
Log Message
[GStreamer] Log a warning if playbin is not found
https://bugs.webkit.org/show_bug.cgi?id=210112
Reviewed by Philippe Normand.
I spent quite a bit of time looking in the debugger for what ended up
being a trivial configuration issue because there was no logging
showing any obvious problem. Let's add it.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259642 => 259643)
--- trunk/Source/WebCore/ChangeLog 2020-04-07 16:29:16 UTC (rev 259642)
+++ trunk/Source/WebCore/ChangeLog 2020-04-07 16:38:32 UTC (rev 259643)
@@ -1,3 +1,17 @@
+2020-04-07 Alicia Boya García <[email protected]>
+
+ [GStreamer] Log a warning if playbin is not found
+ https://bugs.webkit.org/show_bug.cgi?id=210112
+
+ Reviewed by Philippe Normand.
+
+ I spent quite a bit of time looking in the debugger for what ended up
+ being a trivial configuration issue because there was no logging
+ showing any obvious problem. Let's add it.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::isAvailable):
+
2020-04-07 Adrian Perez de Castro <[email protected]>
[GTK] CMake find module for GTK4
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (259642 => 259643)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-04-07 16:29:16 UTC (rev 259642)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-04-07 16:38:32 UTC (rev 259643)
@@ -548,6 +548,8 @@
// FIXME: This has not been updated for the playbin3 switch.
GRefPtr<GstElementFactory> factory = adoptGRef(gst_element_factory_find("playbin"));
+ if (!factory)
+ GST_WARNING("Couldn't find a factory for the playbin element. Media playback will be disabled.");
return factory;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
