Title: [259660] trunk/Tools
- Revision
- 259660
- Author
- [email protected]
- Date
- 2020-04-07 12:59:24 -0700 (Tue, 07 Apr 2020)
Log Message
[ews] Add unit-test for CheckPatchRelevance build step
https://bugs.webkit.org/show_bug.cgi?id=210140
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
(TestCheckPatchRelevance):
(TestCheckPatchRelevance.test_relevant_patch):
(TestCheckPatchRelevance.test_non_relevant_patch):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (259659 => 259660)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-04-07 19:43:30 UTC (rev 259659)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-04-07 19:59:24 UTC (rev 259660)
@@ -2151,6 +2151,41 @@
return self.runStep()
+class TestCheckPatchRelevance(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ self.longMessage = True
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_relevant_patch(self):
+ CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: JSTests/'
+ self.setupStep(CheckPatchRelevance())
+ self.setProperty('buildername', 'JSC-Tests-EWS')
+ self.assertEqual(CheckPatchRelevance.haltOnFailure, True)
+ self.assertEqual(CheckPatchRelevance.flunkOnFailure, True)
+ self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
+ return self.runStep()
+
+ def test_queue_without_relevance_info(self):
+ CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
+ self.setupStep(CheckPatchRelevance())
+ self.setProperty('buildername', 'Commit-Queue')
+ CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
+ self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
+ return self.runStep()
+
+ def test_non_relevant_patch(self):
+ CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
+ self.setupStep(CheckPatchRelevance())
+ self.setProperty('buildername', 'JSC-Tests-EWS')
+ self.setProperty('patch_id', '1234')
+ CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
+ self.expectOutcome(result=FAILURE, state_string='Checked patch relevance (failure)')
+ return self.runStep()
+
+
class TestArchiveBuiltProduct(BuildStepMixinAdditions, unittest.TestCase):
def setUp(self):
self.longMessage = True
Modified: trunk/Tools/ChangeLog (259659 => 259660)
--- trunk/Tools/ChangeLog 2020-04-07 19:43:30 UTC (rev 259659)
+++ trunk/Tools/ChangeLog 2020-04-07 19:59:24 UTC (rev 259660)
@@ -1,3 +1,15 @@
+2020-04-07 Aakash Jain <[email protected]>
+
+ [ews] Add unit-test for CheckPatchRelevance build step
+ https://bugs.webkit.org/show_bug.cgi?id=210140
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
+ (TestCheckPatchRelevance):
+ (TestCheckPatchRelevance.test_relevant_patch):
+ (TestCheckPatchRelevance.test_non_relevant_patch):
+
2020-04-07 Kate Cheney <[email protected]>
Return app-bound sessions for instances where WKAppBoundDomains is
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
