Title: [259667] trunk/Tools
- Revision
- 259667
- Author
- [email protected]
- Date
- 2020-04-07 13:23:50 -0700 (Tue, 07 Apr 2020)
Log Message
Unreviewed, reverting r259446.
Broke Windows testing
Reverted changeset:
"[Windows] Ignore render tree dump based results on Windows"
https://bugs.webkit.org/show_bug.cgi?id=209897
https://trac.webkit.org/changeset/259446
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (259666 => 259667)
--- trunk/Tools/ChangeLog 2020-04-07 20:17:53 UTC (rev 259666)
+++ trunk/Tools/ChangeLog 2020-04-07 20:23:50 UTC (rev 259667)
@@ -1,3 +1,15 @@
+2020-04-07 Truitt Savell <[email protected]>
+
+ Unreviewed, reverting r259446.
+
+ Broke Windows testing
+
+ Reverted changeset:
+
+ "[Windows] Ignore render tree dump based results on Windows"
+ https://bugs.webkit.org/show_bug.cgi?id=209897
+ https://trac.webkit.org/changeset/259446
+
2020-04-07 Aakash Jain <[email protected]>
[ews] Add unit-test for CheckPatchRelevance build step
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (259666 => 259667)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2020-04-07 20:17:53 UTC (rev 259666)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2020-04-07 20:23:50 UTC (rev 259667)
@@ -235,8 +235,6 @@
def _compare_text(self, expected_text, actual_text):
failures = []
- if self._options.ignore_render_tree_dump_results and self._render_tree_dump_pattern.match(actual_text):
- return failures
if (expected_text and actual_text and
# Assuming expected_text is already normalized.
self._port.do_text_results_differ(expected_text, self._get_normalized_output_text(actual_text))):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (259666 => 259667)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-04-07 20:17:53 UTC (rev 259666)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-04-07 20:23:50 UTC (rev 259667)
@@ -149,9 +149,6 @@
dest="sample_on_timeout", help="Don't run sample on timeout (OS X only)"),
optparse.make_option("--no-ref-tests", action=""
dest="no_ref_tests", help="Skip all ref tests"),
- optparse.make_option("--ignore-render-tree-dump-results", action=""
- dest="ignore_render_tree_dump_results",
- help="Don't compare or save results for render tree dump tests (they still run and crashes are reported)"),
optparse.make_option("--tolerance",
help="Ignore image differences less than this percentage (some "
"ports may ignore this option)", type="float"),
@@ -472,10 +469,6 @@
if options.platform in ["gtk", "wpe"]:
options.webkit_test_runner = True
- # Don't maintain render tree dump results for Apple Windows port.
- if port.port_name == "win":
- options.ignore_render_tree_dump_results = True
-
if options.leaks:
options.additional_env_var.append("JSC_usePoisoning=0")
options.additional_env_var.append("__XPC_JSC_usePoisoning=0")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
