[webkit-changes] [259699] trunk/Tools

Tue, 07 Apr 2020 18:40:10 -0700

Title: [259699] trunk/Tools
Revision
259699
Author
[email protected]
Date
2020-04-07 18:38:41 -0700 (Tue, 07 Apr 2020)

Log Message

[ews] Add unit tests for layout tests factories
https://bugs.webkit.org/show_bug.cgi?id=210150

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/factories_unittest.py:
(TestLayoutTestsFactory):
(TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
(TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
(TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
(TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
(TestGTKFactory): Renamed.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py (259698 => 259699)


--- trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py	2020-04-08 00:59:37 UTC (rev 259698)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py	2020-04-08 01:38:41 UTC (rev 259699)
@@ -203,7 +203,71 @@
         ])
 
 
-class TestGTKFactory(TestCase):
+class TestLayoutTestsFactory(TestCase):
+    def test_macos_wk1_release_factory(self):
+        factory = factories.macOSWK1Factory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKit1Tests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_macos_wk1_debug_factory(self):
+        factory = factories.macOSWK1Factory(platform='mac-mojave', configuration='debug', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='debug', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKit1Tests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_macos_wk2_factory(self):
+        factory = factories.macOSWK2Factory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKitTests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_ios_wk2_factory(self):
+        factory = factories.iOSTestsFactory(platform='ios-simulator-13', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='ios-simulator-13', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKitTests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
     def test_gtk_factory(self):
         factory = factories.GTKTestsFactory(platform='gtk', configuration='release', architectures=["x86_64"])
         self.assertBuildSteps(factory.steps, [

Modified: trunk/Tools/ChangeLog (259698 => 259699)


--- trunk/Tools/ChangeLog	2020-04-08 00:59:37 UTC (rev 259698)
+++ trunk/Tools/ChangeLog	2020-04-08 01:38:41 UTC (rev 259699)
@@ -1,5 +1,20 @@
 2020-04-07  Aakash Jain  <[email protected]>
 
+        [ews] Add unit tests for layout tests factories
+        https://bugs.webkit.org/show_bug.cgi?id=210150
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/factories_unittest.py:
+        (TestLayoutTestsFactory):
+        (TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
+        (TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
+        (TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
+        (TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
+        (TestGTKFactory): Renamed.
+
+2020-04-07  Aakash Jain  <[email protected]>
+
         [ews] Improve summary for CheckPatchRelevance build step
         https://bugs.webkit.org/show_bug.cgi?id=210146
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to