Title: [259724] trunk/Source/WebKit
- Revision
- 259724
- Author
- [email protected]
- Date
- 2020-04-08 10:14:09 -0700 (Wed, 08 Apr 2020)
Log Message
Ref WebProcessProxy in NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses()
https://bugs.webkit.org/show_bug.cgi?id=210196
Reviewed by Youenn Fablet.
Ref WebProcessProxy in NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses()
since the call to WebProcessProxy::disableServiceWorkers() may cause it to get destroyed
otherwise.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259723 => 259724)
--- trunk/Source/WebKit/ChangeLog 2020-04-08 17:07:14 UTC (rev 259723)
+++ trunk/Source/WebKit/ChangeLog 2020-04-08 17:14:09 UTC (rev 259724)
@@ -1,5 +1,19 @@
2020-04-08 Chris Dumez <[email protected]>
+ Ref WebProcessProxy in NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses()
+ https://bugs.webkit.org/show_bug.cgi?id=210196
+
+ Reviewed by Youenn Fablet.
+
+ Ref WebProcessProxy in NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses()
+ since the call to WebProcessProxy::disableServiceWorkers() may cause it to get destroyed
+ otherwise.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
+
+2020-04-08 Chris Dumez <[email protected]>
+
Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception
https://bugs.webkit.org/show_bug.cgi?id=210159
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (259723 => 259724)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-04-08 17:07:14 UTC (rev 259723)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-04-08 17:14:09 UTC (rev 259724)
@@ -412,7 +412,7 @@
void NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses(WebCore::ProcessIdentifier processIdentifier)
{
- if (auto* process = WebProcessProxy::processForIdentifier(processIdentifier)) {
+ if (auto process = makeRefPtr(WebProcessProxy::processForIdentifier(processIdentifier))) {
process->disableServiceWorkers();
process->requestTermination(ProcessTerminationReason::ExceededCPULimit);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
