Title: [259743] trunk/Source/WebKit
- Revision
- 259743
- Author
- [email protected]
- Date
- 2020-04-08 12:12:10 -0700 (Wed, 08 Apr 2020)
Log Message
Remove unused WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary and WebProcessPool::sendToOneProcess
https://bugs.webkit.org/show_bug.cgi?id=210199
Patch by Michael Catanzaro <[email protected]> on 2020-04-08
Reviewed by Alex Christensen.
Remove unused functions.
* UIProcess/WebProcessPool.h:
(WebKit::WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary): Deleted.
(WebKit::WebProcessPool::sendToOneProcess): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259742 => 259743)
--- trunk/Source/WebKit/ChangeLog 2020-04-08 19:06:39 UTC (rev 259742)
+++ trunk/Source/WebKit/ChangeLog 2020-04-08 19:12:10 UTC (rev 259743)
@@ -1,3 +1,16 @@
+2020-04-08 Michael Catanzaro <[email protected]>
+
+ Remove unused WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary and WebProcessPool::sendToOneProcess
+ https://bugs.webkit.org/show_bug.cgi?id=210199
+
+ Reviewed by Alex Christensen.
+
+ Remove unused functions.
+
+ * UIProcess/WebProcessPool.h:
+ (WebKit::WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary): Deleted.
+ (WebKit::WebProcessPool::sendToOneProcess): Deleted.
+
2020-04-08 Devin Rousso <[email protected]>
Web Inspector: only broadcast the console message to main frames
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (259742 => 259743)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.h 2020-04-08 19:06:39 UTC (rev 259742)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h 2020-04-08 19:12:10 UTC (rev 259743)
@@ -192,8 +192,6 @@
template<typename T> void sendToAllProcesses(const T& message);
template<typename T> void sendToAllProcessesForSession(const T& message, PAL::SessionID);
- template<typename T> void sendToAllProcessesRelaunchingThemIfNecessary(const T& message);
- template<typename T> void sendToOneProcess(T&& message);
// Sends the message to WebProcess or NetworkProcess as approporiate for current process model.
template<typename T> void sendToNetworkingProcess(T&& message);
@@ -844,33 +842,4 @@
}
}
-template<typename T>
-void WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary(const T& message)
-{
- // FIXME (Multi-WebProcess): WebProcessPool doesn't track processes that have exited, so it cannot relaunch these. Perhaps this functionality won't be needed in this mode.
- sendToAllProcesses(message);
-}
-
-template<typename T>
-void WebProcessPool::sendToOneProcess(T&& message)
-{
- bool messageSent = false;
- size_t processCount = m_processes.size();
- for (size_t i = 0; i < processCount; ++i) {
- WebProcessProxy* process = m_processes[i].get();
- if (process->canSendMessage()) {
- process->send(std::forward<T>(message), 0);
- messageSent = true;
- break;
- }
- }
-
- if (!messageSent) {
- prewarmProcess();
- RefPtr<WebProcessProxy> process = m_processes.last();
- if (process->canSendMessage())
- process->send(std::forward<T>(message), 0);
- }
-}
-
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
