Title: [259798] trunk/Source/WebCore
- Revision
- 259798
- Author
- [email protected]
- Date
- 2020-04-09 07:20:59 -0700 (Thu, 09 Apr 2020)
Log Message
Use more WeakPtr in RenderTreeBuilder::FirstLetter
https://bugs.webkit.org/show_bug.cgi?id=210251
<rdar://problem/61180381>
Reviewed by Zalan Bujtas.
For safety.
* rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259797 => 259798)
--- trunk/Source/WebCore/ChangeLog 2020-04-09 14:16:14 UTC (rev 259797)
+++ trunk/Source/WebCore/ChangeLog 2020-04-09 14:20:59 UTC (rev 259798)
@@ -1,3 +1,16 @@
+2020-04-09 Antti Koivisto <[email protected]>
+
+ Use more WeakPtr in RenderTreeBuilder::FirstLetter
+ https://bugs.webkit.org/show_bug.cgi?id=210251
+ <rdar://problem/61180381>
+
+ Reviewed by Zalan Bujtas.
+
+ For safety.
+
+ * rendering/updating/RenderTreeBuilderFirstLetter.cpp:
+ (WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
+
2020-04-09 Delan Azabani <[email protected]>
Remove unnecessary explicit parsing for mo@maxsize value "infinity"
Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp (259797 => 259798)
--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp 2020-04-09 14:16:14 UTC (rev 259797)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp 2020-04-09 14:20:59 UTC (rev 259798)
@@ -251,7 +251,7 @@
}
auto* textNode = currentTextChild.textNode();
- auto* beforeChild = currentTextChild.nextSibling();
+ auto beforeChild = makeWeakPtr(currentTextChild.nextSibling());
auto inlineWrapperForDisplayContents = makeWeakPtr(currentTextChild.inlineWrapperForDisplayContents());
auto hasInlineWrapperForDisplayContents = inlineWrapperForDisplayContents.get();
m_builder.destroy(currentTextChild);
@@ -268,7 +268,7 @@
RenderTextFragment& remainingText = *newRemainingText;
ASSERT_UNUSED(hasInlineWrapperForDisplayContents, hasInlineWrapperForDisplayContents == inlineWrapperForDisplayContents.get());
remainingText.setInlineWrapperForDisplayContents(inlineWrapperForDisplayContents.get());
- m_builder.attach(*textContentParent, WTFMove(newRemainingText), beforeChild);
+ m_builder.attach(*textContentParent, WTFMove(newRemainingText), beforeChild.get());
// FIXME: Make attach the final step so that we don't need to keep firstLetter around.
auto& firstLetter = *newFirstLetter;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
