Title: [259813] trunk/Source/WebCore
Revision
259813
Author
an...@apple.com
Date
2020-04-09 12:23:10 -0700 (Thu, 09 Apr 2020)

Log Message

Removed unused fields and functions from StylePropertyShorthand
https://bugs.webkit.org/show_bug.cgi?id=210279

Reviewed by Darin Adler.

* css/StylePropertyShorthand.cpp:
(WebCore::borderAbridgedShorthand): Deleted.
* css/StylePropertyShorthand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties const):
(WebCore::StylePropertyShorthand::propertiesForInitialization const): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (259812 => 259813)


--- trunk/Source/WebCore/ChangeLog	2020-04-09 19:20:53 UTC (rev 259812)
+++ trunk/Source/WebCore/ChangeLog	2020-04-09 19:23:10 UTC (rev 259813)
@@ -1,3 +1,17 @@
+2020-04-09  Antti Koivisto  <an...@apple.com>
+
+        Removed unused fields and functions from StylePropertyShorthand
+        https://bugs.webkit.org/show_bug.cgi?id=210279
+
+        Reviewed by Darin Adler.
+
+        * css/StylePropertyShorthand.cpp:
+        (WebCore::borderAbridgedShorthand): Deleted.
+        * css/StylePropertyShorthand.h:
+        (WebCore::StylePropertyShorthand::StylePropertyShorthand):
+        (WebCore::StylePropertyShorthand::properties const):
+        (WebCore::StylePropertyShorthand::propertiesForInitialization const): Deleted.
+
 2020-04-08  Simon Fraser  <simon.fra...@apple.com>
 
         [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes

Modified: trunk/Source/WebCore/css/StylePropertyShorthand.cpp (259812 => 259813)


--- trunk/Source/WebCore/css/StylePropertyShorthand.cpp	2020-04-09 19:20:53 UTC (rev 259812)
+++ trunk/Source/WebCore/css/StylePropertyShorthand.cpp	2020-04-09 19:23:10 UTC (rev 259813)
@@ -25,13 +25,6 @@
 
 namespace WebCore {
 
-StylePropertyShorthand borderAbridgedShorthand()
-{
-    static const CSSPropertyID borderAbridgedProperties[] = { CSSPropertyBorderWidth, CSSPropertyBorderStyle, CSSPropertyBorderColor };
-    static const StylePropertyShorthand propertiesForInitialization[] = { borderWidthShorthand(), borderStyleShorthand(), borderColorShorthand() };
-    return StylePropertyShorthand(CSSPropertyBorder, borderAbridgedProperties, propertiesForInitialization);
-}
-
 StylePropertyShorthand animationShorthandForParsing()
 {
     // Animation-name must come last, so that keywords for other properties in the shorthand

Modified: trunk/Source/WebCore/css/StylePropertyShorthand.h (259812 => 259813)


--- trunk/Source/WebCore/css/StylePropertyShorthand.h	2020-04-09 19:20:53 UTC (rev 259812)
+++ trunk/Source/WebCore/css/StylePropertyShorthand.h	2020-04-09 19:23:10 UTC (rev 259813)
@@ -31,9 +31,8 @@
     StylePropertyShorthand() = default;
 
     template<unsigned numProperties>
-    StylePropertyShorthand(CSSPropertyID id, const CSSPropertyID (&properties)[numProperties], const StylePropertyShorthand* propertiesForInitialization = nullptr)
+    StylePropertyShorthand(CSSPropertyID id, const CSSPropertyID (&properties)[numProperties])
         : m_properties(properties)
-        , m_propertiesForInitialization(propertiesForInitialization)
         , m_length(numProperties)
         , m_shorthandID(id)
     {
@@ -43,13 +42,11 @@
     const CSSPropertyID* end() const { return properties() + length(); }
 
     const CSSPropertyID* properties() const { return m_properties; }
-    const StylePropertyShorthand* propertiesForInitialization() const { return m_propertiesForInitialization; }
     unsigned length() const { return m_length; }
     CSSPropertyID id() const { return m_shorthandID; }
 
 private:
     const CSSPropertyID* m_properties { nullptr };
-    const StylePropertyShorthand* m_propertiesForInitialization { nullptr };
     unsigned m_length { 0 };
     CSSPropertyID m_shorthandID { CSSPropertyInvalid };
 };
@@ -57,7 +54,6 @@
 // Custom StylePropertyShorthand functions.
 StylePropertyShorthand animationShorthandForParsing();
 StylePropertyShorthand transitionShorthandForParsing();
-StylePropertyShorthand borderAbridgedShorthand();
 
 // Returns empty value if the property is not a shorthand.
 // The implementation is generated in StylePropertyShorthandFunctions.cpp.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to