Title: [259831] trunk/LayoutTests
- Revision
- 259831
- Author
- [email protected]
- Date
- 2020-04-09 14:50:49 -0700 (Thu, 09 Apr 2020)
Log Message
[iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=210305
<rdar://problem/61539886>
Fix up the test. All sub-tests are expected to find editable elements. This is a result
of a last minute realization that I need to iterate over all the hit views instead of just
the frontmost one because the search rect can overlap multiple layers: See "iterate over all
the hit views" in <https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
true that the search rect contains an editable element even though that element may be occluded
by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
negatives are not.
* editing/editable-region/hit-test-overlap-expected.txt:
* editing/editable-region/hit-test-overlap.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (259830 => 259831)
--- trunk/LayoutTests/ChangeLog 2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/ChangeLog 2020-04-09 21:50:49 UTC (rev 259831)
@@ -1,3 +1,21 @@
+2020-04-09 Daniel Bates <[email protected]>
+
+ [iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
+ https://bugs.webkit.org/show_bug.cgi?id=210305
+ <rdar://problem/61539886>
+
+ Fix up the test. All sub-tests are expected to find editable elements. This is a result
+ of a last minute realization that I need to iterate over all the hit views instead of just
+ the frontmost one because the search rect can overlap multiple layers: See "iterate over all
+ the hit views" in <https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
+ requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
+ true that the search rect contains an editable element even though that element may be occluded
+ by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
+ negatives are not.
+
+ * editing/editable-region/hit-test-overlap-expected.txt:
+ * editing/editable-region/hit-test-overlap.html:
+
2020-04-09 Said Abou-Hallawa <[email protected]>
REGRESSION: CSS animations inside an embedded SVG image do not animate
Modified: trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt (259830 => 259831)
--- trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt 2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt 2020-04-09 21:50:49 UTC (rev 259831)
@@ -9,8 +9,8 @@
PASS (x = 281, y = 69, width = 249, height = 201) contains editable elements.
Composited overlap:
-PASS (x = 29, y = 343, width = 251, height = 201) does not contain editable elements.
-PASS (x = 270, y = 400, width = 10, height = 10) does not contain editable elements.
+PASS (x = 29, y = 343, width = 251, height = 201) contains editable elements.
+PASS (x = 270, y = 400, width = 10, height = 10) contains editable elements.
PASS (x = 281, y = 343, width = 249, height = 201) contains editable elements.
PASS successfullyParsed is true
Modified: trunk/LayoutTests/editing/editable-region/hit-test-overlap.html (259830 => 259831)
--- trunk/LayoutTests/editing/editable-region/hit-test-overlap.html 2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/editing/editable-region/hit-test-overlap.html 2020-04-09 21:50:49 UTC (rev 259831)
@@ -90,8 +90,8 @@
containerComputedStyle = window.getComputedStyle(container);
overlapper = container.querySelector(".overlapper");
borderLength = parseInt(containerComputedStyle.borderLeftWidth, 10); // Assumes uniform border width
- await shouldNotHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
- await shouldNotHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
+ await shouldHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
+ await shouldHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
await shouldHaveEditableElementsInRect(container.offsetLeft + overlapper.offsetWidth + borderLength, container.offsetTop + borderLength, container.offsetWidth - overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
let testContainer = document.getElementById("test-container");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
