Title: [259834] trunk/Tools
- Revision
- 259834
- Author
- andresg...@apple.com
- Date
- 2020-04-09 15:17:29 -0700 (Thu, 09 Apr 2020)
Log Message
WKAccessibilityRootObject must run on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=210306
Reviewed by Chris Fleizach.
WKAccessibilityRootObject needs to run on the main thread because makes
calls into Document and Page. So reverting the change to make it run on
the AX thread. This means that we cannot simulate getting the root
object on the secondary thread at the moment, as it would with an
accessibility client that supports isolated tree mode. So it is a
tradeoff made for the time being to be able to make progress in testing
the rest of the functionality of AXIsolatedTree/Object.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::accessibleElementById):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (259833 => 259834)
--- trunk/Tools/ChangeLog 2020-04-09 22:08:48 UTC (rev 259833)
+++ trunk/Tools/ChangeLog 2020-04-09 22:17:29 UTC (rev 259834)
@@ -1,3 +1,21 @@
+2020-04-09 Andres Gonzalez <andresg...@apple.com>
+
+ WKAccessibilityRootObject must run on the main thread.
+ https://bugs.webkit.org/show_bug.cgi?id=210306
+
+ Reviewed by Chris Fleizach.
+
+ WKAccessibilityRootObject needs to run on the main thread because makes
+ calls into Document and Page. So reverting the change to make it run on
+ the AX thread. This means that we cannot simulate getting the root
+ object on the secondary thread at the moment, as it would with an
+ accessibility client that supports isolated tree mode. So it is a
+ tradeoff made for the time being to be able to make progress in testing
+ the rest of the functionality of AXIsolatedTree/Object.
+
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
+ (WTR::AccessibilityController::accessibleElementById):
+
2020-04-09 David Kilzer <ddkil...@apple.com>
Add using WTF::isInBounds to CheckedArithmetic.h
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm (259833 => 259834)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm 2020-04-09 22:08:48 UTC (rev 259833)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm 2020-04-09 22:17:29 UTC (rev 259834)
@@ -97,12 +97,8 @@
RefPtr<AccessibilityUIElement> AccessibilityController::accessibleElementById(JSStringRef idAttribute)
{
WKBundlePageRef page = InjectedBundle::singleton().page()->page();
- PlatformUIElement root = nullptr;
+ PlatformUIElement root = static_cast<PlatformUIElement>(WKAccessibilityRootObject(page));
- executeOnAXThreadIfPossible([&page, &root] {
- root = static_cast<PlatformUIElement>(WKAccessibilityRootObject(page));
- });
-
id result;
executeOnAXThreadIfPossible([&root, &idAttribute, &result] {
result = findAccessibleObjectById(root, [NSString stringWithJSStringRef:idAttribute]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
