Log Message
Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC <https://webkit.org/b/210316>
Reviewed by Alex Christensen. * Platform/IPC/ArgumentCoder.h: * Platform/IPC/ArgumentCoders.cpp: (IPC::ArgumentCoder<WallTime>::decode): (IPC::ArgumentCoder<AtomString>::decode): (IPC::ArgumentCoder<CString>::decode): (IPC::ArgumentCoder<String>::decode): (IPC::ArgumentCoder<SHA1::Digest>::decode): (IPC::ArgumentCoder<audit_token_t>::decode): (IPC::ArgumentCoder<Monostate>::decode): * Platform/IPC/ArgumentCoders.h: (IPC::SimpleArgumentCoder::decode): (IPC::ArgumentCoder<OptionSet<T>>::decode): (IPC::ArgumentCoder<Optional<T>>::decode): (IPC::ArgumentCoder<Box<T>>::decode): (IPC::TupleDecoderImpl::decode): (IPC::TupleDecoderImpl<Type>::decode): (IPC::TupleDecoder::decode): (IPC::TupleDecoder<0>::decode): (IPC::VariantCoder::decode): * Platform/IPC/Attachment.h: * Platform/IPC/DataReference.h: * Platform/IPC/Decoder.h: (IPC::Decoder::decodeEnum): * Platform/IPC/FormDataReference.h: (IPC::FormDataReference::decode): * Platform/IPC/ImageDataReference.h: (IPC::ImageDataReference::decode): * Platform/IPC/SharedBufferDataReference.h: (IPC::SharedBufferDataReference::decode): * Platform/IPC/StringReference.h: * Platform/IPC/cocoa/MachPort.h: (IPC::MachPort::decode):
Modified Paths
- trunk/Source/WebKit/ChangeLog
- trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h
- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp
- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h
- trunk/Source/WebKit/Platform/IPC/Attachment.h
- trunk/Source/WebKit/Platform/IPC/DataReference.h
- trunk/Source/WebKit/Platform/IPC/Decoder.h
- trunk/Source/WebKit/Platform/IPC/FormDataReference.h
- trunk/Source/WebKit/Platform/IPC/ImageDataReference.h
- trunk/Source/WebKit/Platform/IPC/SharedBufferDataReference.h
- trunk/Source/WebKit/Platform/IPC/StringReference.h
- trunk/Source/WebKit/Platform/IPC/cocoa/MachPort.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259846 => 259847)
--- trunk/Source/WebKit/ChangeLog 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/ChangeLog 2020-04-10 05:48:35 UTC (rev 259847)
@@ -1,3 +1,43 @@
+2020-04-09 David Kilzer <ddkil...@apple.com>
+
+ Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC
+ <https://webkit.org/b/210316>
+
+ Reviewed by Alex Christensen.
+
+ * Platform/IPC/ArgumentCoder.h:
+ * Platform/IPC/ArgumentCoders.cpp:
+ (IPC::ArgumentCoder<WallTime>::decode):
+ (IPC::ArgumentCoder<AtomString>::decode):
+ (IPC::ArgumentCoder<CString>::decode):
+ (IPC::ArgumentCoder<String>::decode):
+ (IPC::ArgumentCoder<SHA1::Digest>::decode):
+ (IPC::ArgumentCoder<audit_token_t>::decode):
+ (IPC::ArgumentCoder<Monostate>::decode):
+ * Platform/IPC/ArgumentCoders.h:
+ (IPC::SimpleArgumentCoder::decode):
+ (IPC::ArgumentCoder<OptionSet<T>>::decode):
+ (IPC::ArgumentCoder<Optional<T>>::decode):
+ (IPC::ArgumentCoder<Box<T>>::decode):
+ (IPC::TupleDecoderImpl::decode):
+ (IPC::TupleDecoderImpl<Type>::decode):
+ (IPC::TupleDecoder::decode):
+ (IPC::TupleDecoder<0>::decode):
+ (IPC::VariantCoder::decode):
+ * Platform/IPC/Attachment.h:
+ * Platform/IPC/DataReference.h:
+ * Platform/IPC/Decoder.h:
+ (IPC::Decoder::decodeEnum):
+ * Platform/IPC/FormDataReference.h:
+ (IPC::FormDataReference::decode):
+ * Platform/IPC/ImageDataReference.h:
+ (IPC::ImageDataReference::decode):
+ * Platform/IPC/SharedBufferDataReference.h:
+ (IPC::SharedBufferDataReference::decode):
+ * Platform/IPC/StringReference.h:
+ * Platform/IPC/cocoa/MachPort.h:
+ (IPC::MachPort::decode):
+
2020-04-09 Alex Christensen <achristen...@webkit.org>
IPC serialization of enums should serialize std::underlying_type instead of uint64_t
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -99,13 +99,13 @@
t.encode(encoder);
}
- template<typename U = T, std::enable_if_t<UsesLegacyDecoder<U>::argumentCoderValue>* = nullptr>
+ template<typename U = T, std::enable_if_t<UsesLegacyDecoder<U>::argumentCoderValue>* = nullptr> WARN_UNUSED_RETURN
static bool decode(Decoder& decoder, U& u)
{
return U::decode(decoder, u);
}
- template<typename U = T, std::enable_if_t<UsesModernDecoder<U>::argumentCoderValue>* = nullptr>
+ template<typename U = T, std::enable_if_t<UsesModernDecoder<U>::argumentCoderValue>* = nullptr> WARN_UNUSED_RETURN
static Optional<U> decode(Decoder& decoder)
{
return U::decode(decoder);
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp 2020-04-10 05:48:35 UTC (rev 259847)
@@ -37,7 +37,7 @@
encoder << time.secondsSinceEpoch().value();
}
-bool ArgumentCoder<WallTime>::decode(Decoder& decoder, WallTime& time)
+WARN_UNUSED_RETURN bool ArgumentCoder<WallTime>::decode(Decoder& decoder, WallTime& time)
{
double value;
if (!decoder.decode(value))
@@ -47,7 +47,7 @@
return true;
}
-Optional<WallTime> ArgumentCoder<WallTime>::decode(Decoder& decoder)
+WARN_UNUSED_RETURN Optional<WallTime> ArgumentCoder<WallTime>::decode(Decoder& decoder)
{
Optional<double> time;
decoder >> time;
@@ -61,7 +61,7 @@
encoder << atomString.string();
}
-bool ArgumentCoder<AtomString>::decode(Decoder& decoder, AtomString& atomString)
+WARN_UNUSED_RETURN bool ArgumentCoder<AtomString>::decode(Decoder& decoder, AtomString& atomString)
{
String string;
if (!decoder.decode(string))
@@ -84,7 +84,7 @@
encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(string.data()), length, 1);
}
-bool ArgumentCoder<CString>::decode(Decoder& decoder, CString& result)
+WARN_UNUSED_RETURN bool ArgumentCoder<CString>::decode(Decoder& decoder, CString& result)
{
uint32_t length;
if (!decoder.decode(length))
@@ -131,7 +131,7 @@
encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(string.characters16()), length * sizeof(UChar), alignof(UChar));
}
-template <typename CharacterType>
+template <typename CharacterType> WARN_UNUSED_RETURN
static inline Optional<String> decodeStringText(Decoder& decoder, uint32_t length)
{
// Before allocating the string, make sure that the decoder buffer is big enough.
@@ -148,7 +148,7 @@
return string;
}
-Optional<String> ArgumentCoder<String>::decode(Decoder& decoder)
+WARN_UNUSED_RETURN Optional<String> ArgumentCoder<String>::decode(Decoder& decoder)
{
uint32_t length;
if (!decoder.decode(length))
@@ -168,7 +168,7 @@
return decodeStringText<UChar>(decoder, length);
}
-bool ArgumentCoder<String>::decode(Decoder& decoder, String& result)
+WARN_UNUSED_RETURN bool ArgumentCoder<String>::decode(Decoder& decoder, String& result)
{
Optional<String> string;
decoder >> string;
@@ -183,7 +183,7 @@
encoder.encodeFixedLengthData(digest.data(), sizeof(digest), 1);
}
-bool ArgumentCoder<SHA1::Digest>::decode(Decoder& decoder, SHA1::Digest& digest)
+WARN_UNUSED_RETURN bool ArgumentCoder<SHA1::Digest>::decode(Decoder& decoder, SHA1::Digest& digest)
{
return decoder.decodeFixedLengthData(digest.data(), sizeof(digest), 1);
}
@@ -195,7 +195,7 @@
encoder << auditToken.val[i];
}
-bool ArgumentCoder<audit_token_t>::decode(Decoder& decoder, audit_token_t& auditToken)
+WARN_UNUSED_RETURN bool ArgumentCoder<audit_token_t>::decode(Decoder& decoder, audit_token_t& auditToken)
{
for (unsigned i = 0; i < WTF_ARRAY_LENGTH(auditToken.val); i++) {
if (!decoder.decode(auditToken.val[i]))
@@ -209,7 +209,7 @@
{
}
-Optional<Monostate> ArgumentCoder<Monostate>::decode(Decoder&)
+WARN_UNUSED_RETURN Optional<Monostate> ArgumentCoder<Monostate>::decode(Decoder&)
{
return Monostate { };
}
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -46,7 +46,7 @@
encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(&t), sizeof(T), alignof(T));
}
- static bool decode(Decoder& decoder, T& t)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, T& t)
{
return decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(&t), sizeof(T), alignof(T));
}
@@ -58,7 +58,7 @@
encoder << (static_cast<uint64_t>(optionSet.toRaw()));
}
- static bool decode(Decoder& decoder, OptionSet<T>& optionSet)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, OptionSet<T>& optionSet)
{
uint64_t value;
if (!decoder.decode(value))
@@ -68,7 +68,7 @@
return true;
}
- static Optional<OptionSet<T>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<OptionSet<T>> decode(Decoder& decoder)
{
Optional<uint64_t> value;
decoder >> value;
@@ -90,7 +90,7 @@
encoder << optional.value();
}
- static bool decode(Decoder& decoder, Optional<T>& optional)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, Optional<T>& optional)
{
bool isEngaged;
if (!decoder.decode(isEngaged))
@@ -109,7 +109,7 @@
return true;
}
- static Optional<Optional<T>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<Optional<T>> decode(Decoder& decoder)
{
Optional<bool> isEngaged;
decoder >> isEngaged;
@@ -138,7 +138,7 @@
encoder << *box.get();
}
- static bool decode(Decoder& decoder, Box<T>& box)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, Box<T>& box)
{
bool isEngaged;
if (!decoder.decode(isEngaged))
@@ -157,7 +157,7 @@
return true;
}
- static Optional<Box<T>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<Box<T>> decode(Decoder& decoder)
{
Optional<bool> isEngaged;
decoder >> isEngaged;
@@ -180,7 +180,7 @@
encoder << pair.first << pair.second;
}
- static bool decode(Decoder& decoder, std::pair<T, U>& pair)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, std::pair<T, U>& pair)
{
T first;
if (!decoder.decode(first))
@@ -195,7 +195,7 @@
return true;
}
- static Optional<std::pair<T, U>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<std::pair<T, U>> decode(Decoder& decoder)
{
Optional<T> first;
decoder >> first;
@@ -241,7 +241,7 @@
template<typename Type, typename... Types>
struct TupleDecoderImpl {
- static Optional<std::tuple<Type, Types...>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<std::tuple<Type, Types...>> decode(Decoder& decoder)
{
Optional<Type> optional;
decoder >> optional;
@@ -258,7 +258,7 @@
template<typename Type>
struct TupleDecoderImpl<Type> {
- static Optional<std::tuple<Type>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<std::tuple<Type>> decode(Decoder& decoder)
{
Optional<Type> optional;
decoder >> optional;
@@ -270,7 +270,7 @@
template<size_t size, typename... Elements>
struct TupleDecoder {
- static Optional<std::tuple<Elements...>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<std::tuple<Elements...>> decode(Decoder& decoder)
{
return TupleDecoderImpl<Elements...>::decode(decoder);
}
@@ -278,7 +278,7 @@
template<>
struct TupleDecoder<0> {
- static Optional<std::tuple<>> decode(Decoder&)
+ static WARN_UNUSED_RETURN Optional<std::tuple<>> decode(Decoder&)
{
return std::make_tuple();
}
@@ -290,7 +290,7 @@
TupleEncoder<sizeof...(Elements), Elements...>::encode(encoder, tuple);
}
- static Optional<std::tuple<Elements...>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<std::tuple<Elements...>> decode(Decoder& decoder)
{
return TupleDecoder<sizeof...(Elements), Elements...>::decode(decoder);
}
@@ -302,7 +302,7 @@
encoder << pair.key << pair.value;
}
- static bool decode(Decoder& decoder, WTF::KeyValuePair<KeyType, ValueType>& pair)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, WTF::KeyValuePair<KeyType, ValueType>& pair)
{
KeyType key;
if (!decoder.decode(key))
@@ -328,7 +328,7 @@
encoder << vector[i];
}
- static bool decode(Decoder& decoder, Vector<T, inlineCapacity, OverflowHandler, minCapacity>& vector)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, Vector<T, inlineCapacity, OverflowHandler, minCapacity>& vector)
{
Optional<Vector<T, inlineCapacity, OverflowHandler, minCapacity>> optional;
decoder >> optional;
@@ -338,7 +338,7 @@
return true;
}
- static Optional<Vector<T, inlineCapacity, OverflowHandler, minCapacity>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<Vector<T, inlineCapacity, OverflowHandler, minCapacity>> decode(Decoder& decoder)
{
uint64_t size;
if (!decoder.decode(size))
@@ -364,7 +364,7 @@
encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(vector.data()), vector.size() * sizeof(T), alignof(T));
}
- static bool decode(Decoder& decoder, Vector<T, inlineCapacity, OverflowHandler, minCapacity>& vector)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, Vector<T, inlineCapacity, OverflowHandler, minCapacity>& vector)
{
uint64_t decodedSize;
if (!decoder.decode(decodedSize)) {
@@ -399,7 +399,7 @@
return true;
}
- static Optional<Vector<T, inlineCapacity, OverflowHandler, minCapacity>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<Vector<T, inlineCapacity, OverflowHandler, minCapacity>> decode(Decoder& decoder)
{
uint64_t decodedSize;
if (!decoder.decode(decodedSize)) {
@@ -446,7 +446,7 @@
encoder << *it;
}
- static Optional<HashMapType> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<HashMapType> decode(Decoder& decoder)
{
uint32_t hashMapSize;
if (!decoder.decode(hashMapSize))
@@ -479,7 +479,7 @@
return hashMap;
}
- static bool decode(Decoder& decoder, HashMapType& hashMap)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, HashMapType& hashMap)
{
Optional<HashMapType> tempHashMap;
decoder >> tempHashMap;
@@ -500,7 +500,7 @@
encoder << *it;
}
- static bool decode(Decoder& decoder, HashSetType& hashSet)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, HashSetType& hashSet)
{
Optional<HashSetType> tempHashSet;
decoder >> tempHashSet;
@@ -511,7 +511,7 @@
return true;
}
- static Optional<HashSetType> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<HashSetType> decode(Decoder& decoder)
{
uint64_t hashSetSize;
if (!decoder.decode(hashSetSize))
@@ -553,7 +553,7 @@
}
}
- static bool decode(Decoder& decoder, HashCountedSetType& hashCountedSet)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, HashCountedSetType& hashCountedSet)
{
uint64_t hashCountedSetSize;
if (!decoder.decode(hashCountedSetSize))
@@ -598,7 +598,7 @@
encoder << expected.value();
}
- static Optional<Expected<ValueType, ErrorType>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<Expected<ValueType, ErrorType>> decode(Decoder& decoder)
{
Optional<bool> hasValue;
decoder >> hasValue;
@@ -633,7 +633,7 @@
VariantCoder<index - 1, Types...>::encode(encoder, variant, i);
}
- static Optional<WTF::Variant<Types...>> decode(Decoder& decoder, unsigned i)
+ static WARN_UNUSED_RETURN Optional<WTF::Variant<Types...>> decode(Decoder& decoder, unsigned i)
{
if (i == index) {
Optional<typename WTF::variant_alternative<index, WTF::Variant<Types...>>::type> optional;
@@ -654,7 +654,7 @@
encoder << WTF::get<0>(variant);
}
- static Optional<WTF::Variant<Types...>> decode(Decoder& decoder, unsigned i)
+ static WARN_UNUSED_RETURN Optional<WTF::Variant<Types...>> decode(Decoder& decoder, unsigned i)
{
ASSERT_UNUSED(i, !i);
Optional<typename WTF::variant_alternative<0, WTF::Variant<Types...>>::type> optional;
@@ -673,7 +673,7 @@
VariantCoder<sizeof...(Types) - 1, Types...>::encode(encoder, variant, i);
}
- static Optional<WTF::Variant<Types...>> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<WTF::Variant<Types...>> decode(Decoder& decoder)
{
Optional<unsigned> i;
decoder >> i;
@@ -685,41 +685,41 @@
template<> struct ArgumentCoder<WallTime> {
static void encode(Encoder&, const WallTime&);
- static bool decode(Decoder&, WallTime&);
- static Optional<WallTime> decode(Decoder&);
+ static bool decode(Decoder&, WallTime&) WARN_UNUSED_RETURN;
+ static Optional<WallTime> decode(Decoder&) WARN_UNUSED_RETURN;
};
template<> struct ArgumentCoder<AtomString> {
static void encode(Encoder&, const AtomString&);
- static bool decode(Decoder&, AtomString&);
+ static bool decode(Decoder&, AtomString&) WARN_UNUSED_RETURN;
};
template<> struct ArgumentCoder<CString> {
static void encode(Encoder&, const CString&);
- static bool decode(Decoder&, CString&);
+ static bool decode(Decoder&, CString&) WARN_UNUSED_RETURN;
};
template<> struct ArgumentCoder<String> {
static void encode(Encoder&, const String&);
- static bool decode(Decoder&, String&);
- static Optional<String> decode(Decoder&);
+ static bool decode(Decoder&, String&) WARN_UNUSED_RETURN;
+ static Optional<String> decode(Decoder&) WARN_UNUSED_RETURN;
};
template<> struct ArgumentCoder<SHA1::Digest> {
static void encode(Encoder&, const SHA1::Digest&);
- static bool decode(Decoder&, SHA1::Digest&);
+ static bool decode(Decoder&, SHA1::Digest&) WARN_UNUSED_RETURN;
};
#if HAVE(AUDIT_TOKEN)
template<> struct ArgumentCoder<audit_token_t> {
static void encode(Encoder&, const audit_token_t&);
- static bool decode(Decoder&, audit_token_t&);
+ static bool decode(Decoder&, audit_token_t&) WARN_UNUSED_RETURN;
};
#endif
template<> struct ArgumentCoder<Monostate> {
static void encode(Encoder&, const Monostate&);
- static Optional<Monostate> decode(Decoder&);
+ static Optional<Monostate> decode(Decoder&) WARN_UNUSED_RETURN;
};
} // namespace IPC
Modified: trunk/Source/WebKit/Platform/IPC/Attachment.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/Attachment.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/Attachment.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -86,7 +86,7 @@
#endif
void encode(Encoder&) const;
- static bool decode(Decoder&, Attachment&);
+ static bool decode(Decoder&, Attachment&) WARN_UNUSED_RETURN;
private:
Type m_type;
Modified: trunk/Source/WebKit/Platform/IPC/DataReference.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/DataReference.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/DataReference.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -68,7 +68,7 @@
}
void encode(Encoder&) const;
- static bool decode(Decoder&, DataReference&);
+ static bool decode(Decoder&, DataReference&) WARN_UNUSED_RETURN;
private:
const uint8_t* m_data { nullptr };
Modified: trunk/Source/WebKit/Platform/IPC/Decoder.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/Decoder.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/Decoder.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -81,30 +81,30 @@
bool decodeFixedLengthData(uint8_t*, size_t, unsigned alignment) WARN_UNUSED_RETURN;
// The data in the data reference here will only be valid for the lifetime of the ArgumentDecoder object.
- bool decodeVariableLengthByteArray(DataReference&);
+ bool decodeVariableLengthByteArray(DataReference&) WARN_UNUSED_RETURN;
- bool decode(bool&);
+ bool decode(bool&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<bool>&);
- bool decode(uint8_t&);
+ bool decode(uint8_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<uint8_t>&);
- bool decode(uint16_t&);
+ bool decode(uint16_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<uint16_t>&);
- bool decode(uint32_t&);
+ bool decode(uint32_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<uint32_t>&);
- bool decode(uint64_t&);
+ bool decode(uint64_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<uint64_t>&);
- bool decode(int16_t&);
+ bool decode(int16_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<int16_t>&);
- bool decode(int32_t&);
+ bool decode(int32_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<int32_t>&);
- bool decode(int64_t&);
+ bool decode(int64_t&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<int64_t>&);
- bool decode(float&);
+ bool decode(float&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<float>&);
- bool decode(double&);
+ bool decode(double&) WARN_UNUSED_RETURN;
Decoder& operator>>(Optional<double>&);
- template<typename E, typename = std::enable_if_t<std::is_enum<E>::value>>
+ template<typename E, typename = std::enable_if_t<std::is_enum<E>::value>> WARN_UNUSED_RETURN
bool decode(E& e)
{
typename std::underlying_type<E>::type value;
@@ -127,7 +127,8 @@
return *this;
}
- template<typename T> bool decodeEnum(T& result)
+ template<typename T> WARN_UNUSED_RETURN
+ bool decodeEnum(T& result)
{
typename std::underlying_type<T>::type value;
if (!decode(value))
@@ -148,13 +149,13 @@
return bufferIsLargeEnoughToContain(alignof(T), numElements * sizeof(T));
}
- template<typename T, std::enable_if_t<!std::is_enum<T>::value && UsesLegacyDecoder<T>::value>* = nullptr>
+ template<typename T, std::enable_if_t<!std::is_enum<T>::value && UsesLegacyDecoder<T>::value>* = nullptr> WARN_UNUSED_RETURN
bool decode(T& t)
{
return ArgumentCoder<T>::decode(*this, t);
}
- template<typename T, std::enable_if_t<!std::is_enum<T>::value && !UsesLegacyDecoder<T>::value>* = nullptr>
+ template<typename T, std::enable_if_t<!std::is_enum<T>::value && !UsesLegacyDecoder<T>::value>* = nullptr> WARN_UNUSED_RETURN
bool decode(T& t)
{
Optional<T> optional;
Modified: trunk/Source/WebKit/Platform/IPC/FormDataReference.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/FormDataReference.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/FormDataReference.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -67,7 +67,7 @@
encoder << sandboxExtensionHandles;
}
- static Optional<FormDataReference> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<FormDataReference> decode(Decoder& decoder)
{
Optional<bool> hasFormData;
decoder >> hasFormData;
Modified: trunk/Source/WebKit/Platform/IPC/ImageDataReference.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ImageDataReference.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ImageDataReference.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -46,7 +46,7 @@
encoder << m_imageData;
}
- static Optional<ImageDataReference> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<ImageDataReference> decode(Decoder& decoder)
{
Optional<RefPtr<WebCore::ImageData>> imageData;
decoder >> imageData;
Modified: trunk/Source/WebKit/Platform/IPC/SharedBufferDataReference.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/SharedBufferDataReference.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/SharedBufferDataReference.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -53,7 +53,7 @@
encoder << m_buffer;
}
- static Optional<SharedBufferDataReference> decode(Decoder& decoder)
+ static WARN_UNUSED_RETURN Optional<SharedBufferDataReference> decode(Decoder& decoder)
{
Optional<RefPtr<WebCore::SharedBuffer>> buffer;
decoder >> buffer;
Modified: trunk/Source/WebKit/Platform/IPC/StringReference.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/StringReference.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/StringReference.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -64,7 +64,7 @@
CString toString() const;
void encode(Encoder&) const;
- static bool decode(Decoder&, StringReference&);
+ static bool decode(Decoder&, StringReference&) WARN_UNUSED_RETURN;
struct Hash {
static unsigned hash(const StringReference& a);
Modified: trunk/Source/WebKit/Platform/IPC/cocoa/MachPort.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/cocoa/MachPort.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/cocoa/MachPort.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -50,7 +50,7 @@
encoder << Attachment(m_port, m_disposition);
}
- static bool decode(Decoder& decoder, MachPort& p)
+ static WARN_UNUSED_RETURN bool decode(Decoder& decoder, MachPort& p)
{
Attachment attachment;
if (!decoder.decode(attachment))
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
