Title: [259851] trunk/Source/_javascript_Core
- Revision
- 259851
- Author
- ysuz...@apple.com
- Date
- 2020-04-10 00:39:57 -0700 (Fri, 10 Apr 2020)
Log Message
Unreviewed, fix typo in comment
https://bugs.webkit.org/show_bug.cgi?id=209395
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_put_by_id):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259850 => 259851)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-10 06:55:13 UTC (rev 259850)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-10 07:39:57 UTC (rev 259851)
@@ -1,3 +1,17 @@
+2020-04-10 Yusuke Suzuki <ysuz...@apple.com>
+
+ Unreviewed, fix typo in comment
+ https://bugs.webkit.org/show_bug.cgi?id=209395
+
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::emitPutByValWithCachedId):
+ (JSC::JIT::emit_op_del_by_id):
+ (JSC::JIT::emit_op_del_by_val):
+ (JSC::JIT::emit_op_put_by_id):
+ * jit/JITPropertyAccess32_64.cpp:
+ (JSC::JIT::emitPutByValWithCachedId):
+ (JSC::JIT::emit_op_put_by_id):
+
2020-04-09 Yusuke Suzuki <ysuz...@apple.com>
[JSC] Use UnconditionalWriteBarrier in Baseline effectively to reduce code size
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (259850 => 259851)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2020-04-10 06:55:13 UTC (rev 259850)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2020-04-10 07:39:57 UTC (rev 259851)
@@ -290,7 +290,7 @@
JSValueRegs(regT0), JSValueRegs(regT1), regT2, bytecode.m_ecmaMode, putKind);
gen.generateFastPath(*this);
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
emitWriteBarrier(base, UnconditionalWriteBarrier);
doneCases.append(jump());
@@ -408,7 +408,7 @@
emitPutVirtualRegister(dst, JSValueRegs(regT0));
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
// We should emit write-barrier at the end of sequence since write-barrier clobbers registers.
emitWriteBarrier(base, UnconditionalWriteBarrier);
}
@@ -457,7 +457,7 @@
// We should emit write-barrier at the end of sequence since write-barrier clobbers registers.
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
emitWriteBarrier(base, UnconditionalWriteBarrier);
}
@@ -675,7 +675,7 @@
m_putByIds.append(gen);
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
emitWriteBarrier(baseVReg, UnconditionalWriteBarrier);
}
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (259850 => 259851)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2020-04-10 06:55:13 UTC (rev 259850)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2020-04-10 07:39:57 UTC (rev 259851)
@@ -369,7 +369,7 @@
// reload the registers.
//
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
// We are emitting write-barrier before writing here but this is OK since 32bit JSC does not have concurrent GC.
emitWriteBarrier(base, UnconditionalWriteBarrier);
emitLoadPayload(base, regT0);
@@ -622,7 +622,7 @@
m_putByIds.append(gen);
// IC can write new Structure without write-barrier if a base is cell.
- // We emit write-barrier unconditionally since we know baseVRege is a cell.
+ // We emit write-barrier unconditionally since we know base is a cell.
emitWriteBarrier(base, UnconditionalWriteBarrier);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
