Title: [259968] releases/WebKitGTK/webkit-2.28/Source/WebCore
- Revision
- 259968
- Author
- [email protected]
- Date
- 2020-04-12 06:16:47 -0700 (Sun, 12 Apr 2020)
Log Message
Merge r259073 - [GStreamer] Fix missing NULL-check in setSyncOnClock
https://bugs.webkit.org/show_bug.cgi?id=209609
Unreviewed, simple fix.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setSyncOnClock): Some systems are configured so that
audio sinks are not available. Make sure not to crash when asking
to sync with a NULL sink.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (259967 => 259968)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-04-12 13:04:20 UTC (rev 259967)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-04-12 13:16:47 UTC (rev 259968)
@@ -1,3 +1,15 @@
+2020-03-26 Charlie Turner <[email protected]>
+
+ [GStreamer] Fix missing NULL-check in setSyncOnClock
+ https://bugs.webkit.org/show_bug.cgi?id=209609
+
+ Unreviewed, simple fix.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::setSyncOnClock): Some systems are configured so that
+ audio sinks are not available. Make sure not to crash when asking
+ to sync with a NULL sink.
+
2020-03-27 Miguel Gomez <[email protected]>
[WPE] Unnecessary gl synchronization when using an OpenMAX video decoder and GLES2
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (259967 => 259968)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-04-12 13:04:20 UTC (rev 259967)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-04-12 13:16:47 UTC (rev 259968)
@@ -1243,6 +1243,9 @@
static void setSyncOnClock(GstElement *element, bool sync)
{
+ if (!element)
+ return;
+
if (!GST_IS_BIN(element)) {
g_object_set(element, "sync", sync, NULL);
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
