Title: [259993] branches/safari-609-branch/Source/WebCore
- Revision
- 259993
- Author
- [email protected]
- Date
- 2020-04-12 20:48:29 -0700 (Sun, 12 Apr 2020)
Log Message
Cherry-pick r257901. rdar://problem/61269751
Remove unused variable m_allUniqueIDBDatabases in IDBServer
https://bugs.webkit.org/show_bug.cgi?id=208613
Reviewed by Chris Dumez.
* Modules/indexeddb/server/IDBServer.h:
(WebCore::IDBServer::IDBServer::addDatabase): Deleted.
(WebCore::IDBServer::IDBServer::removeDatabase): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (259992 => 259993)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-13 03:37:33 UTC (rev 259992)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-13 03:48:29 UTC (rev 259993)
@@ -1,3 +1,36 @@
+2020-04-12 Alan Coon <[email protected]>
+
+ Cherry-pick r257901. rdar://problem/61269751
+
+ Remove unused variable m_allUniqueIDBDatabases in IDBServer
+ https://bugs.webkit.org/show_bug.cgi?id=208613
+
+ Reviewed by Chris Dumez.
+
+ * Modules/indexeddb/server/IDBServer.h:
+ (WebCore::IDBServer::IDBServer::addDatabase): Deleted.
+ (WebCore::IDBServer::IDBServer::removeDatabase): Deleted.
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
+ (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-03-04 Sihui Liu <[email protected]>
+
+ Remove unused variable m_allUniqueIDBDatabases in IDBServer
+ https://bugs.webkit.org/show_bug.cgi?id=208613
+
+ Reviewed by Chris Dumez.
+
+ * Modules/indexeddb/server/IDBServer.h:
+ (WebCore::IDBServer::IDBServer::addDatabase): Deleted.
+ (WebCore::IDBServer::IDBServer::removeDatabase): Deleted.
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
+ (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
+
2020-04-10 Alan Coon <[email protected]>
Cherry-pick r259830. rdar://problem/61596886
Modified: branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/IDBServer.h (259992 => 259993)
--- branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/IDBServer.h 2020-04-13 03:37:33 UTC (rev 259992)
+++ branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/IDBServer.h 2020-04-13 03:48:29 UTC (rev 259993)
@@ -110,9 +110,6 @@
Lock& lock() { return m_lock; };
- void addDatabase(UniqueIDBDatabase& database) { m_allUniqueIDBDatabases.add(database); }
- void removeDatabase(UniqueIDBDatabase& database) { m_allUniqueIDBDatabases.remove(database); }
-
private:
UniqueIDBDatabase& getOrCreateUniqueIDBDatabase(const IDBDatabaseIdentifier&);
@@ -125,7 +122,6 @@
PAL::SessionID m_sessionID;
HashMap<IDBConnectionIdentifier, RefPtr<IDBConnectionToClient>> m_connectionMap;
HashMap<IDBDatabaseIdentifier, std::unique_ptr<UniqueIDBDatabase>> m_uniqueIDBDatabaseMap;
- WeakHashSet<UniqueIDBDatabase> m_allUniqueIDBDatabases;
HashMap<uint64_t, UniqueIDBDatabaseConnection*> m_databaseConnections;
HashMap<IDBResourceIdentifier, UniqueIDBDatabaseTransaction*> m_transactions;
Modified: branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (259992 => 259993)
--- branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2020-04-13 03:37:33 UTC (rev 259992)
+++ branches/safari-609-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2020-04-13 03:48:29 UTC (rev 259993)
@@ -116,7 +116,6 @@
{
ASSERT(!isMainThread());
- m_server.addDatabase(*this);
LOG(IndexedDB, "UniqueIDBDatabase::UniqueIDBDatabase() (%p) %s", this, m_identifier.loggingString().utf8().data());
}
@@ -132,8 +131,6 @@
ASSERT(!m_versionChangeTransaction);
ASSERT(!m_versionChangeDatabaseConnection);
RELEASE_ASSERT(!m_backingStore);
-
- m_server.removeDatabase(*this);
}
const IDBDatabaseInfo& UniqueIDBDatabase::info() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
