Title: [260010] trunk/Tools
- Revision
- 260010
- Author
- [email protected]
- Date
- 2020-04-13 09:21:03 -0700 (Mon, 13 Apr 2020)
Log Message
[ews] Improve handling of unexpected network issues while communicating with Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=210377
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
(BugzillaBeautifulSoup.authenticate):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py (260009 => 260010)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py 2020-04-13 15:58:26 UTC (rev 260009)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py 2020-04-13 16:21:03 UTC (rev 260010)
@@ -180,7 +180,11 @@
self.browser['Bugzilla_login'] = username
self.browser['Bugzilla_password'] = password
self.browser.find_control("Bugzilla_restrictlogin").items[0].selected = False
- response = self.browser.submit()
+ try:
+ response = self.browser.submit()
+ except:
+ _log.error('Unexpected error while authenticating to bugzilla.')
+ continue
match = re.search("<title>(.+?)</title>", response.read())
# If the resulting page has a title, and it contains the word
@@ -187,11 +191,11 @@
# "invalid" assume it's the login failure page.
if match and re.search("Invalid", match.group(1), re.IGNORECASE):
errorMessage = 'Bugzilla login failed: {}'.format(match.group(1))
- if attempts >= 5:
+ if attempts >= 3:
# raise an exception only if this was the last attempt
raise Exception(errorMessage)
_log.error(errorMessage)
- time.sleep(5)
+ time.sleep(3)
else:
authenticated = True
Modified: trunk/Tools/ChangeLog (260009 => 260010)
--- trunk/Tools/ChangeLog 2020-04-13 15:58:26 UTC (rev 260009)
+++ trunk/Tools/ChangeLog 2020-04-13 16:21:03 UTC (rev 260010)
@@ -1,5 +1,15 @@
2020-04-13 Aakash Jain <[email protected]>
+ [ews] Improve handling of unexpected network issues while communicating with Bugzilla
+ https://bugs.webkit.org/show_bug.cgi?id=210377
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
+ (BugzillaBeautifulSoup.authenticate):
+
+2020-04-13 Aakash Jain <[email protected]>
+
ews status-bubble hover-over message include unhelpful message 'Crash collection has quiesced'
https://bugs.webkit.org/show_bug.cgi?id=210378
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
