Title: [260012] trunk/Source
Revision
260012
Author
[email protected]
Date
2020-04-13 09:33:31 -0700 (Mon, 13 Apr 2020)

Log Message

Fix various build warnings
https://bugs.webkit.org/show_bug.cgi?id=210429

Patch by Michael Catanzaro <[email protected]> on 2020-04-13
Reviewed by Mark Lam.

Source/_javascript_Core:

Fix -Wimplicit-fallthrough warning by adding a default case CRASH() to prevent the inner
switch from falling through to the outer switch.

* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::alreadyChecked const):

Source/WebCore:

Fix -Wunused-parameter warning.

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImage2DBase):

Source/WebKit:

Use private-code instead of deprecated code command to build the Wayland protocol.

* PlatformGTK.cmake:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (260011 => 260012)


--- trunk/Source/_javascript_Core/ChangeLog	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-04-13 16:33:31 UTC (rev 260012)
@@ -1,3 +1,16 @@
+2020-04-13  Michael Catanzaro  <[email protected]>
+
+        Fix various build warnings
+        https://bugs.webkit.org/show_bug.cgi?id=210429
+
+        Reviewed by Mark Lam.
+
+        Fix -Wimplicit-fallthrough warning by adding a default case CRASH() to prevent the inner
+        switch from falling through to the outer switch.
+
+        * dfg/DFGArrayMode.cpp:
+        (JSC::DFG::ArrayMode::alreadyChecked const):
+
 2020-04-12  Mark Lam  <[email protected]>
 
         Enable the ability to build the ASM LLInt for ARMv7k.

Modified: trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp (260011 => 260012)


--- trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2020-04-13 16:33:31 UTC (rev 260012)
@@ -562,6 +562,8 @@
             }
             return true;
         }
+        default:
+            CRASH();
         }
         
     case Array::DirectArguments:

Modified: trunk/Source/WebCore/ChangeLog (260011 => 260012)


--- trunk/Source/WebCore/ChangeLog	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/WebCore/ChangeLog	2020-04-13 16:33:31 UTC (rev 260012)
@@ -1,3 +1,15 @@
+2020-04-13  Michael Catanzaro  <[email protected]>
+
+        Fix various build warnings
+        https://bugs.webkit.org/show_bug.cgi?id=210429
+
+        Reviewed by Mark Lam.
+
+        Fix -Wunused-parameter warning.
+
+        * html/canvas/WebGLRenderingContextBase.cpp:
+        (WebCore::WebGLRenderingContextBase::texImage2DBase):
+
 2020-04-13  Zalan Bujtas  <[email protected]>
 
         [LFC][TFC] Pre-fill columnIntrinsicWidths vector

Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (260011 => 260012)


--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-04-13 16:33:31 UTC (rev 260012)
@@ -4198,6 +4198,7 @@
 #if USE(ANGLE)
     m_context->getExtensions().texImage2DRobustANGLE(target, level, internalFormat, width, height, border, format, type, byteLength, pixels);
 #else
+    UNUSED_PARAM(byteLength);
     // FIXME: For now we ignore any errors returned.
     auto tex = validateTextureBinding("texImage2D", target, true);
     ASSERT(validateTexFuncParameters("texImage2D", TexImage, target, level, internalFormat, width, height, border, format, type));

Modified: trunk/Source/WebKit/ChangeLog (260011 => 260012)


--- trunk/Source/WebKit/ChangeLog	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/WebKit/ChangeLog	2020-04-13 16:33:31 UTC (rev 260012)
@@ -1,3 +1,14 @@
+2020-04-13  Michael Catanzaro  <[email protected]>
+
+        Fix various build warnings
+        https://bugs.webkit.org/show_bug.cgi?id=210429
+
+        Reviewed by Mark Lam.
+
+        Use private-code instead of deprecated code command to build the Wayland protocol.
+
+        * PlatformGTK.cmake:
+
 2020-04-12  Darin Adler  <[email protected]>
 
         Fix some strange uses of start/endOfDocument

Modified: trunk/Source/WebKit/PlatformGTK.cmake (260011 => 260012)


--- trunk/Source/WebKit/PlatformGTK.cmake	2020-04-13 16:31:39 UTC (rev 260011)
+++ trunk/Source/WebKit/PlatformGTK.cmake	2020-04-13 16:33:31 UTC (rev 260012)
@@ -550,7 +550,7 @@
         DEPENDS ${WEBKIT_DIR}/Shared/gtk/WebKitWaylandProtocol.xml
         COMMAND ${WAYLAND_SCANNER} server-header ${WEBKIT_DIR}/Shared/gtk/WebKitWaylandProtocol.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitWaylandServerProtocol.h
         COMMAND ${WAYLAND_SCANNER} client-header ${WEBKIT_DIR}/Shared/gtk/WebKitWaylandProtocol.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitWaylandClientProtocol.h
-        COMMAND ${WAYLAND_SCANNER} code ${WEBKIT_DIR}/Shared/gtk/WebKitWaylandProtocol.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitWaylandClientProtocol.c
+        COMMAND ${WAYLAND_SCANNER} private-code ${WEBKIT_DIR}/Shared/gtk/WebKitWaylandProtocol.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitWaylandClientProtocol.c
         VERBATIM
     )
 
@@ -557,7 +557,7 @@
     add_custom_command(
         OUTPUT ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/pointer-constraints-unstable-v1-protocol.c
         DEPENDS ${WAYLAND_PROTOCOLS_DATADIR}/unstable/pointer-constraints/pointer-constraints-unstable-v1.xml
-        COMMAND ${WAYLAND_SCANNER} code ${WAYLAND_PROTOCOLS_DATADIR}/unstable/pointer-constraints/pointer-constraints-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/pointer-constraints-unstable-v1-protocol.c
+        COMMAND ${WAYLAND_SCANNER} private-code ${WAYLAND_PROTOCOLS_DATADIR}/unstable/pointer-constraints/pointer-constraints-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/pointer-constraints-unstable-v1-protocol.c
         COMMAND ${WAYLAND_SCANNER} client-header ${WAYLAND_PROTOCOLS_DATADIR}/unstable/pointer-constraints/pointer-constraints-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/pointer-constraints-unstable-v1-client-protocol.h
         VERBATIM
     )
@@ -565,7 +565,7 @@
     add_custom_command(
         OUTPUT ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/relative-pointer-unstable-v1-protocol.c
         DEPENDS ${WAYLAND_PROTOCOLS_DATADIR}/unstable/relative-pointer/relative-pointer-unstable-v1.xml
-        COMMAND ${WAYLAND_SCANNER} code ${WAYLAND_PROTOCOLS_DATADIR}/unstable/relative-pointer/relative-pointer-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/relative-pointer-unstable-v1-protocol.c
+        COMMAND ${WAYLAND_SCANNER} private-code ${WAYLAND_PROTOCOLS_DATADIR}/unstable/relative-pointer/relative-pointer-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/relative-pointer-unstable-v1-protocol.c
         COMMAND ${WAYLAND_SCANNER} client-header ${WAYLAND_PROTOCOLS_DATADIR}/unstable/relative-pointer/relative-pointer-unstable-v1.xml ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/relative-pointer-unstable-v1-client-protocol.h
         VERBATIM
     )
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to