- Revision
- 260014
- Author
- [email protected]
- Date
- 2020-04-13 09:40:04 -0700 (Mon, 13 Apr 2020)
Log Message
Unreviewed. Remove redundant move in return statement.
Return statement already returns rvalue,
so we don't need move here.
This patch removes the build warning below since r259922.
warning: redundant move in return statement [-Wredundant-move]
Source/WebCore:
No new tests, no new behaviours.
* page/csp/ContentSecurityPolicyResponseHeaders.h:
(WebCore::ContentSecurityPolicyResponseHeaders::decode):
* platform/network/cf/CertificateInfoCFNet.cpp:
(WTF::Persistence::decodeSecTrustRef):
Source/WebKit:
* NetworkProcess/cache/NetworkCacheCoders.cpp:
(WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::decode):
Source/WTF:
* wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<CString>::decode):
(WTF::Persistence::decodeStringText):
(WTF::Persistence::Coder<SHA1::Digest>::decode):
* wtf/persistence/PersistentCoders.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (260013 => 260014)
--- trunk/Source/WTF/ChangeLog 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WTF/ChangeLog 2020-04-13 16:40:04 UTC (rev 260014)
@@ -1,3 +1,19 @@
+2020-04-13 Joonghun Park <[email protected]>
+
+ Unreviewed. Remove redundant move in return statement.
+
+ Return statement already returns rvalue,
+ so we don't need move here.
+
+ This patch removes the build warning below since r259922.
+ warning: redundant move in return statement [-Wredundant-move]
+
+ * wtf/persistence/PersistentCoders.cpp:
+ (WTF::Persistence::Coder<CString>::decode):
+ (WTF::Persistence::decodeStringText):
+ (WTF::Persistence::Coder<SHA1::Digest>::decode):
+ * wtf/persistence/PersistentCoders.h:
+
2020-04-12 Mark Lam <[email protected]>
Enable the ability to build the ASM LLInt for ARMv7k.
Modified: trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp (260013 => 260014)
--- trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp 2020-04-13 16:40:04 UTC (rev 260014)
@@ -81,7 +81,7 @@
if (!decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(buffer), *length))
return WTF::nullopt;
- return WTFMove(string);
+ return string;
}
void Coder<String>::encode(Encoder& encoder, const String& string)
@@ -115,7 +115,7 @@
if (!decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(buffer), length * sizeof(CharacterType)))
return WTF::nullopt;
- return WTFMove(string);
+ return string;
}
Optional<String> Coder<String>::decode(Decoder& decoder)
@@ -150,7 +150,7 @@
SHA1::Digest tmp;
if (!decoder.decodeFixedLengthData(tmp.data(), sizeof(tmp)))
return WTF::nullopt;
- return WTFMove(tmp);
+ return tmp;
}
}
Modified: trunk/Source/WTF/wtf/persistence/PersistentCoders.h (260013 => 260014)
--- trunk/Source/WTF/wtf/persistence/PersistentCoders.h 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WTF/wtf/persistence/PersistentCoders.h 2020-04-13 16:40:04 UTC (rev 260014)
@@ -141,7 +141,7 @@
}
tmp.shrinkToFit();
- return WTFMove(tmp);
+ return tmp;
}
};
@@ -176,7 +176,7 @@
if (!decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(temp.data()), size * sizeof(T)))
return WTF::nullopt;
- return WTFMove(temp);
+ return temp;
}
};
@@ -217,7 +217,7 @@
}
}
- return WTFMove(tempHashMap);
+ return tempHashMap;
}
};
@@ -251,7 +251,7 @@
}
}
- return WTFMove(tempHashSet);
+ return tempHashSet;
}
};
Modified: trunk/Source/WebCore/ChangeLog (260013 => 260014)
--- trunk/Source/WebCore/ChangeLog 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WebCore/ChangeLog 2020-04-13 16:40:04 UTC (rev 260014)
@@ -1,3 +1,20 @@
+2020-04-13 Joonghun Park <[email protected]>
+
+ Unreviewed. Remove redundant move in return statement.
+
+ Return statement already returns rvalue,
+ so we don't need move here.
+
+ This patch removes the build warning below since r259922.
+ warning: redundant move in return statement [-Wredundant-move]
+
+ No new tests, no new behaviours.
+
+ * page/csp/ContentSecurityPolicyResponseHeaders.h:
+ (WebCore::ContentSecurityPolicyResponseHeaders::decode):
+ * platform/network/cf/CertificateInfoCFNet.cpp:
+ (WTF::Persistence::decodeSecTrustRef):
+
2020-04-13 Youenn Fablet <[email protected]>
Fix mute/unmute of CoreAudioCapture sources after revision 257914
Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h (260013 => 260014)
--- trunk/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h 2020-04-13 16:40:04 UTC (rev 260014)
@@ -111,7 +111,7 @@
return WTF::nullopt;
headers.m_httpStatusCode = *httpStatusCode;
- return WTFMove(headers);
+ return headers;
}
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp (260013 => 260014)
--- trunk/Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp 2020-04-13 16:40:04 UTC (rev 260014)
@@ -217,7 +217,7 @@
if (!trust)
return WTF::nullopt;
- return WTFMove(trust);
+ return trust;
}
#endif
Modified: trunk/Source/WebKit/ChangeLog (260013 => 260014)
--- trunk/Source/WebKit/ChangeLog 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WebKit/ChangeLog 2020-04-13 16:40:04 UTC (rev 260014)
@@ -1,3 +1,16 @@
+2020-04-13 Joonghun Park <[email protected]>
+
+ Unreviewed. Remove redundant move in return statement.
+
+ Return statement already returns rvalue,
+ so we don't need move here.
+
+ This patch removes the build warning below since r259922.
+ warning: redundant move in return statement [-Wredundant-move]
+
+ * NetworkProcess/cache/NetworkCacheCoders.cpp:
+ (WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::decode):
+
2020-04-13 Michael Catanzaro <[email protected]>
Fix various build warnings
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp (260013 => 260014)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp 2020-04-13 16:35:31 UTC (rev 260013)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp 2020-04-13 16:40:04 UTC (rev 260014)
@@ -59,7 +59,7 @@
return WTF::nullopt;
headers.append(WTFMove(*name), WTFMove(*value));
}
- return WTFMove(headers);
+ return headers;
}
}
