Title: [260040] trunk
- Revision
- 260040
- Author
- [email protected]
- Date
- 2020-04-13 14:37:41 -0700 (Mon, 13 Apr 2020)
Log Message
http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=210344
<rdar://problem/61583925>
Reviewed by Brent Fulgham.
Tools:
This patch creates a new TestOption parameter for enabling In-App
Browser Privacy because its NSUserDefaults key is not set using the
internal or experimental keywords. It enables this flag for
WebKitTestRunner if the option is set (and disables it otherwise).
* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformAddTestOptions const):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
LayoutTests:
Update comment to match changes in TestOptions.
* http/tests/in-app-browser-privacy/app-bound-domain.html:
* http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (260039 => 260040)
--- trunk/LayoutTests/ChangeLog 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/LayoutTests/ChangeLog 2020-04-13 21:37:41 UTC (rev 260040)
@@ -1,3 +1,16 @@
+2020-04-13 Kate Cheney <[email protected]>
+
+ http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=210344
+ <rdar://problem/61583925>
+
+ Reviewed by Brent Fulgham.
+
+ Update comment to match changes in TestOptions.
+
+ * http/tests/in-app-browser-privacy/app-bound-domain.html:
+ * http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html:
+
2020-04-13 Jacob Uphoff <[email protected]>
[ macOS ] REGRESSION(r260024) inspector/css/selector-dynamic-specificity.html is constantly failing
Modified: trunk/LayoutTests/http/tests/in-app-browser-privacy/app-bound-domain.html (260039 => 260040)
--- trunk/LayoutTests/http/tests/in-app-browser-privacy/app-bound-domain.html 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/LayoutTests/http/tests/in-app-browser-privacy/app-bound-domain.html 2020-04-13 21:37:41 UTC (rev 260040)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:IsInAppBrowserPrivacyEnabled=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier ] -->
+<!DOCTYPE html><!-- webkit-test-runner [ enableInAppBrowserPrivacy=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier ] -->
<html>
<head>
<script src=""
Modified: trunk/LayoutTests/http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html (260039 => 260040)
--- trunk/LayoutTests/http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/LayoutTests/http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html 2020-04-13 21:37:41 UTC (rev 260040)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:IsInAppBrowserPrivacyEnabled=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier ] -->
+<!DOCTYPE html><!-- webkit-test-runner [ enableInAppBrowserPrivacy=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/Tools/ChangeLog (260039 => 260040)
--- trunk/Tools/ChangeLog 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/Tools/ChangeLog 2020-04-13 21:37:41 UTC (rev 260040)
@@ -1,3 +1,25 @@
+2020-04-13 Kate Cheney <[email protected]>
+
+ http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=210344
+ <rdar://problem/61583925>
+
+ Reviewed by Brent Fulgham.
+
+ This patch creates a new TestOption parameter for enabling In-App
+ Browser Privacy because its NSUserDefaults key is not set using the
+ internal or experimental keywords. It enables this flag for
+ WebKitTestRunner if the option is set (and disables it otherwise).
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::updateTestOptionsFromTestHeader):
+ * WebKitTestRunner/TestOptions.h:
+ (WTR::TestOptions::hasSameInitializationOptions const):
+ * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+ (WTR::TestController::platformAddTestOptions const):
+ * WebKitTestRunner/ios/TestControllerIOS.mm:
+ (WTR::TestController::platformResetStateToConsistentValues):
+
2020-04-13 Per Arne Vollan <[email protected]>
[iOS] Remove unused UTType swizzler code
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (260039 => 260040)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-04-13 21:37:41 UTC (rev 260040)
@@ -1513,6 +1513,8 @@
testOptions.enableCaptureAudioInGPUProcess = parseBooleanTestHeaderValue(value);
else if (key == "allowTopNavigationToDataURLs")
testOptions.allowTopNavigationToDataURLs = parseBooleanTestHeaderValue(value);
+ else if (key == "enableInAppBrowserPrivacy")
+ testOptions.enableInAppBrowserPrivacy = parseBooleanTestHeaderValue(value);
pairStart = pairEnd + 1;
}
Modified: trunk/Tools/WebKitTestRunner/TestOptions.h (260039 => 260040)
--- trunk/Tools/WebKitTestRunner/TestOptions.h 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/Tools/WebKitTestRunner/TestOptions.h 2020-04-13 21:37:41 UTC (rev 260040)
@@ -103,6 +103,7 @@
bool enableCaptureVideoInGPUProcess { true };
bool enableCaptureAudioInGPUProcess { true };
bool allowTopNavigationToDataURLs { true };
+ bool enableInAppBrowserPrivacy { false };
double contentInsetTop { 0 };
@@ -168,7 +169,8 @@
|| enableCaptureVideoInUIProcess != options.enableCaptureVideoInUIProcess
|| enableCaptureVideoInGPUProcess != options.enableCaptureVideoInGPUProcess
|| enableCaptureAudioInGPUProcess != options.enableCaptureAudioInGPUProcess
- || allowTopNavigationToDataURLs != options.allowTopNavigationToDataURLs)
+ || allowTopNavigationToDataURLs != options.allowTopNavigationToDataURLs
+ || enableInAppBrowserPrivacy != options.enableInAppBrowserPrivacy)
return false;
if (!contextOptions.hasSameInitializationOptions(options.contextOptions))
Modified: trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (260039 => 260040)
--- trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2020-04-13 21:37:41 UTC (rev 260040)
@@ -123,6 +123,11 @@
options.contextOptions.enableProcessSwapOnNavigation = true;
if ([[NSUserDefaults standardUserDefaults] boolForKey:@"EnableProcessSwapOnWindowOpen"])
options.contextOptions.enableProcessSwapOnWindowOpen = true;
+
+#if PLATFORM(IOS_FAMILY)
+ if (options.enableInAppBrowserPrivacy)
+ [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"WebKitDebugIsInAppBrowserPrivacyEnabled"];
+#endif
}
void TestController::platformCreateWebView(WKPageConfigurationRef, const TestOptions& options)
Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (260039 => 260040)
--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2020-04-13 21:24:11 UTC (rev 260039)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2020-04-13 21:37:41 UTC (rev 260040)
@@ -214,6 +214,8 @@
if (shouldRestoreFirstResponder)
[mainWebView()->platformView() becomeFirstResponder];
+ [[NSUserDefaults standardUserDefaults] removeObjectForKey:@"WebKitDebugIsInAppBrowserPrivacyEnabled"];
+
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
