Title: [260043] trunk/Source/WebKitLegacy/mac
- Revision
- 260043
- Author
- [email protected]
- Date
- 2020-04-13 15:05:50 -0700 (Mon, 13 Apr 2020)
Log Message
REGRESSION (r259843): "Missing Plug-In" when dragging an image into Mail Compose
https://bugs.webkit.org/show_bug.cgi?id=210458
<rdar://problem/61735361>
Reviewed by Wenson Hsieh.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
r259843 changed this code from making a dictionary with a set of key->object mappings
to making a dictionary with an array of keys as its only key and an array of objects
as that key's value. Not quite the same thing.
Go back to dictionaryWithObjects:forKeys:.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (260042 => 260043)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-04-13 22:02:46 UTC (rev 260042)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-04-13 22:05:50 UTC (rev 260043)
@@ -1,3 +1,19 @@
+2020-04-13 Tim Horton <[email protected]>
+
+ REGRESSION (r259843): "Missing Plug-In" when dragging an image into Mail Compose
+ https://bugs.webkit.org/show_bug.cgi?id=210458
+ <rdar://problem/61735361>
+
+ Reviewed by Wenson Hsieh.
+
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ (WebFrameLoaderClient::createPlugin):
+ r259843 changed this code from making a dictionary with a set of key->object mappings
+ to making a dictionary with an array of keys as its only key and an array of objects
+ as that key's value. Not quite the same thing.
+
+ Go back to dictionaryWithObjects:forKeys:.
+
2020-04-13 David Kilzer <[email protected]>
Fix clang static analyzer warnings about unused instance variables in WebIconDatabase, WKView
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm (260042 => 260043)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2020-04-13 22:02:46 UTC (rev 260042)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2020-04-13 22:05:50 UTC (rev 260043)
@@ -1918,7 +1918,7 @@
#if PLATFORM(MAC)
SEL selector = @selector(webView:plugInViewWithArguments:);
if ([[webView UIDelegate] respondsToSelector:selector]) {
- NSDictionary *attributes = @{ attributeKeys.get(): createNSArray(paramValues).get() };
+ NSDictionary *attributes = [NSDictionary dictionaryWithObjects:createNSArray(paramValues).get() forKeys:attributeKeys.get()];
NSDictionary *arguments = [[NSDictionary alloc] initWithObjectsAndKeys:
attributes, WebPlugInAttributesKey,
@(loadManually ? WebPlugInModeFull : WebPlugInModeEmbed), WebPlugInModeKey,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
