Title: [260068] trunk/Source/WebKit
Revision
260068
Author
[email protected]
Date
2020-04-14 04:26:27 -0700 (Tue, 14 Apr 2020)

Log Message

Do not process RTC Network messages coming from NetworkProcess if LibWebRTCNetwork is not active
https://bugs.webkit.org/show_bug.cgi?id=207376
<rdar://problem/59238611>

Unreviewed.
Post-commit review update, change variable name to network.
No change of behavior.


* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (260067 => 260068)


--- trunk/Source/WebKit/ChangeLog	2020-04-14 10:24:51 UTC (rev 260067)
+++ trunk/Source/WebKit/ChangeLog	2020-04-14 11:26:27 UTC (rev 260068)
@@ -1,3 +1,16 @@
+2020-04-14  Youenn Fablet  <[email protected]>
+
+        Do not process RTC Network messages coming from NetworkProcess if LibWebRTCNetwork is not active
+        https://bugs.webkit.org/show_bug.cgi?id=207376
+        <rdar://problem/59238611>
+
+        Unreviewed.
+        Post-commit review update, change variable name to network.
+        No change of behavior.
+
+        * WebProcess/Network/NetworkProcessConnection.cpp:
+        (WebKit::NetworkProcessConnection::didReceiveMessage):
+
 2020-04-14  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Bring back support for rendering scrollbars using the system appearance

Modified: trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp (260067 => 260068)


--- trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp	2020-04-14 10:24:51 UTC (rev 260067)
+++ trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp	2020-04-14 11:26:27 UTC (rev 260068)
@@ -113,25 +113,25 @@
 
 #if USE(LIBWEBRTC)
     if (decoder.messageReceiverName() == Messages::WebRTCSocket::messageReceiverName()) {
-        auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork();
-        if (libWebRTCNetwork.isActive())
-            libWebRTCNetwork.socket(makeObjectIdentifier<LibWebRTCSocketIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);
+        auto& network = WebProcess::singleton().libWebRTCNetwork();
+        if (network.isActive())
+            network.socket(makeObjectIdentifier<LibWebRTCSocketIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);
         else
             RELEASE_LOG_ERROR(WebRTC, "Received WebRTCSocket message while libWebRTCNetwork is not active");
         return;
     }
     if (decoder.messageReceiverName() == Messages::WebRTCMonitor::messageReceiverName()) {
-        auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork();
-        if (libWebRTCNetwork.isActive())
-            libWebRTCNetwork.monitor().didReceiveMessage(connection, decoder);
+        auto& network = WebProcess::singleton().libWebRTCNetwork();
+        if (network.isActive())
+            network.monitor().didReceiveMessage(connection, decoder);
         else
             RELEASE_LOG_ERROR(WebRTC, "Received WebRTCMonitor message while libWebRTCNetwork is not active");
         return;
     }
     if (decoder.messageReceiverName() == Messages::WebRTCResolver::messageReceiverName()) {
-        auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork();
-        if (libWebRTCNetwork.isActive())
-            libWebRTCNetwork.resolver(makeObjectIdentifier<LibWebRTCResolverIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);
+        auto& network = WebProcess::singleton().libWebRTCNetwork();
+        if (network.isActive())
+            network.resolver(makeObjectIdentifier<LibWebRTCResolverIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);
         else
             RELEASE_LOG_ERROR(WebRTC, "Received WebRTCResolver message while libWebRTCNetwork is not active");
         return;
@@ -139,9 +139,9 @@
 #endif
 #if ENABLE(WEB_RTC)
     if (decoder.messageReceiverName() == Messages::WebMDNSRegister::messageReceiverName()) {
-        auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork();
-        if (libWebRTCNetwork.isActive())
-            libWebRTCNetwork.mdnsRegister().didReceiveMessage(connection, decoder);
+        auto& network = WebProcess::singleton().libWebRTCNetwork();
+        if (network.isActive())
+            network.mdnsRegister().didReceiveMessage(connection, decoder);
         else
             RELEASE_LOG_ERROR(WebRTC, "Received WebMDNSRegister message while libWebRTCNetwork is not active");
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to