Title: [260130] trunk/Tools
Revision
260130
Author
[email protected]
Date
2020-04-15 08:46:50 -0700 (Wed, 15 Apr 2020)

Log Message

REGRESSION: [ Mojave+ Debug WK1 ] Layout Test imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=199117
<rdar://problem/52967035>

Reviewed by Alexey Proskuryakov.

* Scripts/run-_javascript_core-tests: Set JSC_useKernTCSM to false.
* Scripts/webkitpy/port/base.py:
(Port.setup_environ_for_server): Forward JSC_useKernTCSM.
* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Set JSC_useKernTCSM to false.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (260129 => 260130)


--- trunk/Tools/ChangeLog	2020-04-15 15:32:20 UTC (rev 260129)
+++ trunk/Tools/ChangeLog	2020-04-15 15:46:50 UTC (rev 260130)
@@ -1,3 +1,17 @@
+2020-04-15  Jonathan Bedard  <[email protected]>
+
+        REGRESSION: [ Mojave+ Debug WK1 ] Layout Test imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=199117
+        <rdar://problem/52967035>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/run-_javascript_core-tests: Set JSC_useKernTCSM to false.
+        * Scripts/webkitpy/port/base.py:
+        (Port.setup_environ_for_server): Forward JSC_useKernTCSM.
+        * Scripts/webkitpy/port/driver.py:
+        (Driver._setup_environ_for_driver): Set JSC_useKernTCSM to false.
+
 2020-04-15  Devin Rousso  <[email protected]>
 
         [ESNext] Implement logical assignment operators

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (260129 => 260130)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2020-04-15 15:32:20 UTC (rev 260129)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2020-04-15 15:46:50 UTC (rev 260130)
@@ -523,6 +523,10 @@
     }
 }
 
+if (isAppleMacWebKit()) {
+    $envVars .= " JSC_useKernTCSM=false";
+}
+
 my $productDir = jscProductDir();
 $ENV{DYLD_FRAMEWORK_PATH} = $productDir;
 $ENV{JSCTEST_timeout} = 120 unless $ENV{JSCTEST_timeout}; # Set a 120 second timeout on all jsc tests (if environment variable not defined already).

Modified: trunk/Tools/Scripts/webkitpy/port/base.py (260129 => 260130)


--- trunk/Tools/Scripts/webkitpy/port/base.py	2020-04-15 15:32:20 UTC (rev 260129)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2020-04-15 15:46:50 UTC (rev 260130)
@@ -902,6 +902,8 @@
             'DYLD_LIBRARY_PATH',
             '__XPC_DYLD_FRAMEWORK_PATH',
             '__XPC_DYLD_LIBRARY_PATH',
+            'JSC_useKernTCSM',
+            '__XPC_JSC_useKernTCSM',
 
             # CYGWIN:
             'HOMEDRIVE',

Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (260129 => 260130)


--- trunk/Tools/Scripts/webkitpy/port/driver.py	2020-04-15 15:32:20 UTC (rev 260129)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py	2020-04-15 15:46:50 UTC (rev 260130)
@@ -438,6 +438,9 @@
         environment['SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS'] = os.path.realpath(environment['DUMPRENDERTREE_TEMP'])
         environment['__XPC_SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS'] = environment['SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS']
 
+        environment['JSC_useKernTCSM'] = 'false'
+        environment['__XPC_JSC_useKernTCSM'] = environment['JSC_useKernTCSM']
+
         if sys.platform.startswith('linux'):
             # Currently on WebKit2, there is no API for setting the application cache directory.
             # Each worker should have it's own and it should be cleaned afterwards.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to