Title: [260213] branches/safari-610.1.10-branch/Source/WebKit
Revision
260213
Author
[email protected]
Date
2020-04-16 12:44:10 -0700 (Thu, 16 Apr 2020)

Log Message

Cherry-pick r260120. rdar://problem/61899305

    Unreviewed, reverting r259891.

    Causes significant iOS MotionMark regression

    Reverted changeset:

    "Switch unused IOKit classes from allow-with-report to deny-
    with-report"
    https://bugs.webkit.org/show_bug.cgi?id=210136
    https://trac.webkit.org/changeset/259891

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.10-branch/Source/WebKit/ChangeLog (260212 => 260213)


--- branches/safari-610.1.10-branch/Source/WebKit/ChangeLog	2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/ChangeLog	2020-04-16 19:44:10 UTC (rev 260213)
@@ -1,5 +1,36 @@
 2020-04-16  Alan Coon  <[email protected]>
 
+        Cherry-pick r260120. rdar://problem/61899305
+
+    Unreviewed, reverting r259891.
+    
+    Causes significant iOS MotionMark regression
+    
+    Reverted changeset:
+    
+    "Switch unused IOKit classes from allow-with-report to deny-
+    with-report"
+    https://bugs.webkit.org/show_bug.cgi?id=210136
+    https://trac.webkit.org/changeset/259891
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-04-15  Said Abou-Hallawa  <[email protected]>
+
+            Unreviewed, reverting r259891.
+
+            Causes significant iOS MotionMark regression
+
+            Reverted changeset:
+
+            "Switch unused IOKit classes from allow-with-report to deny-
+            with-report"
+            https://bugs.webkit.org/show_bug.cgi?id=210136
+            https://trac.webkit.org/changeset/259891
+
+2020-04-16  Alan Coon  <[email protected]>
+
         Cherry-pick r260193. rdar://problem/61897737
 
     REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable

Modified: branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (260212 => 260213)


--- branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-04-16 19:44:10 UTC (rev 260213)
@@ -205,7 +205,7 @@
 ;;;
 (define-once (opengl)
     ;; Items not seen in testing
-    (deny iokit-open (with telemetry-backtrace)
+    (allow iokit-open (with report) (with telemetry)
            (iokit-connection "IOGPU")
            (iokit-user-client-class
                 "AGXCommandQueue"
@@ -357,7 +357,9 @@
     (allow mach-lookup
         (global-name "com.apple.CARenderServer"))
 
-    (deny iokit-open (with telemetry-backtrace)
+    ; UIKit-required IOKit nodes.
+    (allow iokit-open  (with report) (with telemetry)
+        (iokit-user-client-class "AppleJPEGDriverUserClient")
         (iokit-user-client-class "IOSurfaceSendRight")
     )
 

Modified: branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (260212 => 260213)


--- branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-04-16 19:44:10 UTC (rev 260213)
@@ -120,13 +120,17 @@
         (iokit-registry-entry-class "IOAccelerationUserClient")
         (iokit-registry-entry-class "IOSurfaceRootUserClient")
         (iokit-registry-entry-class "IOSurfaceSendRight"))
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
     ;; CoreVideo CVCGDisplayLink
     (allow iokit-open
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+        (with report) (with telemetry)
+#endif
         (iokit-registry-entry-class "IOFramebufferSharedUserClient"))
-#endif
     ;; H.264 Acceleration
     (allow iokit-open
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+        (with report) (with telemetry)
+#endif
         (iokit-registry-entry-class "AppleIntelMEUserClient")
         (iokit-registry-entry-class "AppleSNBFBUserClient"))
     ;; QuartzCore
@@ -600,30 +604,20 @@
     (allow-read-write-directory-and-issue-read-write-extensions (param "DARWIN_USER_TEMP_DIR")))
 
 ;; IOKit user clients
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
 (allow iokit-open
-    (iokit-user-client-class "AppleMultitouchDeviceUserClient")
-    (iokit-user-client-class "IOHIDParamUserClient")
-    (iokit-user-client-class "IOAudioControlUserClient")
-    (iokit-user-client-class "IOAudioEngineUserClient")
-)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+    (with report) (with telemetry)
 #endif
-
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
-(deny iokit-open
-    (with send-signal SIGKILL)
     (iokit-user-client-class "AppleMultitouchDeviceUserClient")
     (iokit-user-client-class "IOHIDParamUserClient")
     (iokit-user-client-class "IOAudioControlUserClient")
     (iokit-user-client-class "IOAudioEngineUserClient")
-    (iokit-registry-entry-class "IOFramebufferSharedUserClient")
-)
-#endif
+    ;; Following is needed due to <rdar://problem/10427451> && <rdar://problem/10808817>
+    (iokit-user-client-class "AudioAUUC"))
 
 (allow iokit-open
     (iokit-user-client-class "AppleUpstreamUserClient")
     (iokit-user-client-class "RootDomainUserClient") ;; Needed by WebCore::PerformanceMonitor
-    (iokit-user-client-class "AudioAUUC") ;; <rdar://problem/10427451> && <rdar://problem/10808817>
 )
 
 ;; cookied.
@@ -723,9 +717,6 @@
 
 ;; Needed to support encrypted media playback <rdar://problem/40038478>
 (allow mach-lookup
-#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101500
-    (with telemetry-backtrace)
-#endif
     (global-name "com.apple.SecurityServer")
     (global-name "com.apple.ocspd"))
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to