Title: [260297] trunk/Source/_javascript_Core
- Revision
- 260297
- Author
- [email protected]
- Date
- 2020-04-17 16:01:41 -0700 (Fri, 17 Apr 2020)
Log Message
Unreviewed, reverting r260279.
https://bugs.webkit.org/show_bug.cgi?id=210678
Throwing error would be more efficient, having a generic code
is still worth doing (Requested by yusukesuzuki on #webkit).
Reverted changeset:
"[JSC] We do not need to have exit-check for Map/Set iterator
functions"
https://bugs.webkit.org/show_bug.cgi?id=210667
https://trac.webkit.org/changeset/260279
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (260296 => 260297)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-17 23:01:40 UTC (rev 260296)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-17 23:01:41 UTC (rev 260297)
@@ -1,3 +1,18 @@
+2020-04-17 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r260279.
+ https://bugs.webkit.org/show_bug.cgi?id=210678
+
+ Throwing error would be more efficient, having a generic code
+ is still worth doing (Requested by yusukesuzuki on #webkit).
+
+ Reverted changeset:
+
+ "[JSC] We do not need to have exit-check for Map/Set iterator
+ functions"
+ https://bugs.webkit.org/show_bug.cgi?id=210667
+ https://trac.webkit.org/changeset/260279
+
2020-04-17 Saam Barati <[email protected]>
GetTypedArrayByteOffset is broken on arm64e
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (260296 => 260297)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2020-04-17 23:01:40 UTC (rev 260296)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2020-04-17 23:01:41 UTC (rev 260297)
@@ -3188,6 +3188,9 @@
case JSMapValuesIntrinsic:
case JSSetEntriesIntrinsic:
case JSSetValuesIntrinsic: {
+ if (m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCell) || m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadType))
+ return false;
+
insertChecks();
IterationKind kind = IterationKind::Values;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
