Title: [260298] trunk/Tools
Revision
260298
Author
[email protected]
Date
2020-04-17 16:05:37 -0700 (Fri, 17 Apr 2020)

Log Message

Bug 210645: REGRESSION (r211095): [iOS] TestRunnerWKWebView leaks @property accessibilitySpeakSelectionContent
<https://webkit.org/b/210645>
<rdar://problem/61927607>

Reviewed by Chris Fleizach.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
- Release accessibilitySpeakSelectionContent in -dealloc.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (260297 => 260298)


--- trunk/Tools/ChangeLog	2020-04-17 23:01:41 UTC (rev 260297)
+++ trunk/Tools/ChangeLog	2020-04-17 23:05:37 UTC (rev 260298)
@@ -1,3 +1,15 @@
+2020-04-17  David Kilzer  <[email protected]>
+
+        Bug 210645: REGRESSION (r211095): [iOS] TestRunnerWKWebView leaks @property accessibilitySpeakSelectionContent
+        <https://webkit.org/b/210645>
+        <rdar://problem/61927607>
+
+        Reviewed by Chris Fleizach.
+
+        * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
+        (-[TestRunnerWKWebView dealloc]):
+        - Release accessibilitySpeakSelectionContent in -dealloc.
+
 2020-04-17  Brady Eidson  <[email protected]>
 
         Pass sandbox extensions for back/forward list navigations after the policy is decided at process-swap time.

Modified: trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm (260297 => 260298)


--- trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm	2020-04-17 23:01:41 UTC (rev 260297)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm	2020-04-17 23:05:37 UTC (rev 260298)
@@ -120,6 +120,9 @@
     [[NSNotificationCenter defaultCenter] removeObserver:self];
 
     [self resetInteractionCallbacks];
+#if PLATFORM(IOS_FAMILY)
+    self.accessibilitySpeakSelectionContent = nil;
+#endif
 
     self.zoomToScaleCompletionHandler = nil;
     self.retrieveSpeakSelectionContentCompletionHandler = nil;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to