Title: [260309] trunk/Source/_javascript_Core
- Revision
- 260309
- Author
- [email protected]
- Date
- 2020-04-18 07:19:47 -0700 (Sat, 18 Apr 2020)
Log Message
REGRESSION(r260246): It broke build on MIPS32
https://bugs.webkit.org/show_bug.cgi?id=210665
Patch by Angelos Oikonomopoulos <[email protected]> on 2020-04-18
Reviewed by Aakash Jain.
The mnemonic for 'store halfword' is 'sh', not 'shv'. This appears to
be a typo in a path that was never exercised.
Exposed by r260246; riscLowerMisplacedAddresses now calls into
riscAsRegisters with an 'h' suffix, which results in a 'storeh'
instruction. The storeh is then lowered to the non-existent 'shv'.
* offlineasm/mips.rb:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (260308 => 260309)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-18 11:58:13 UTC (rev 260308)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-18 14:19:47 UTC (rev 260309)
@@ -1,3 +1,19 @@
+2020-04-18 Angelos Oikonomopoulos <[email protected]>
+
+ REGRESSION(r260246): It broke build on MIPS32
+ https://bugs.webkit.org/show_bug.cgi?id=210665
+
+ Reviewed by Aakash Jain.
+
+ The mnemonic for 'store halfword' is 'sh', not 'shv'. This appears to
+ be a typo in a path that was never exercised.
+
+ Exposed by r260246; riscLowerMisplacedAddresses now calls into
+ riscAsRegisters with an 'h' suffix, which results in a 'storeh'
+ instruction. The storeh is then lowered to the non-existent 'shv'.
+
+ * offlineasm/mips.rb:
+
2020-04-17 Commit Queue <[email protected]>
Unreviewed, reverting r260279.
Modified: trunk/Source/_javascript_Core/offlineasm/mips.rb (260308 => 260309)
--- trunk/Source/_javascript_Core/offlineasm/mips.rb 2020-04-18 11:58:13 UTC (rev 260308)
+++ trunk/Source/_javascript_Core/offlineasm/mips.rb 2020-04-18 14:19:47 UTC (rev 260309)
@@ -904,7 +904,7 @@
when "loadhsi"
$asm.puts "lh #{mipsFlippedOperands(operands)}"
when "storeh"
- $asm.puts "shv #{mipsOperands(operands)}"
+ $asm.puts "sh #{mipsOperands(operands)}"
when "loadd"
$asm.puts "ldc1 #{mipsFlippedOperands(operands)}"
when "stored"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
