Title: [260348] trunk/Source/WebKit
- Revision
- 260348
- Author
- [email protected]
- Date
- 2020-04-19 20:46:40 -0700 (Sun, 19 Apr 2020)
Log Message
REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc
<https://webkit.org/b/210710>
<rdar://problem/61992856>
Reviewed by Darin Adler.
* Shared/Cocoa/ProcessTaskStateObserver.mm:
(-[WKProcessTaskStateObserverDelegate dealloc]): Add.
- Release _taskStateChangedCallback to fix the leak.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260347 => 260348)
--- trunk/Source/WebKit/ChangeLog 2020-04-20 02:18:32 UTC (rev 260347)
+++ trunk/Source/WebKit/ChangeLog 2020-04-20 03:46:40 UTC (rev 260348)
@@ -1,5 +1,17 @@
2020-04-19 David Kilzer <[email protected]>
+ REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc
+ <https://webkit.org/b/210710>
+ <rdar://problem/61992856>
+
+ Reviewed by Darin Adler.
+
+ * Shared/Cocoa/ProcessTaskStateObserver.mm:
+ (-[WKProcessTaskStateObserverDelegate dealloc]): Add.
+ - Release _taskStateChangedCallback to fix the leak.
+
+2020-04-19 David Kilzer <[email protected]>
+
[IPC hardening] Use MESSAGE_CHECK in WebPageProxy::loadRecentSearches() and WebPageProxy::saveRecentSearches()
<https://webkit.org/b/210683>
<rdar://problem/59240446>
Modified: trunk/Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm (260347 => 260348)
--- trunk/Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm 2020-04-20 02:18:32 UTC (rev 260347)
+++ trunk/Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm 2020-04-20 03:46:40 UTC (rev 260348)
@@ -43,6 +43,12 @@
@end
@implementation WKProcessTaskStateObserverDelegate
+- (void)dealloc
+{
+ [_taskStateChangedCallback release];
+ [super dealloc];
+}
+
- (void)process:(BKSProcess *)process taskStateDidChange:(BKSProcessTaskState)newState
{
RELEASE_LOG(ProcessSuspension, "%p -[WKProcessTaskStateObserverDelegate process:taskStateDidChange:], process(%p), newState(%d)", self, process, (int)newState);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
