Title: [260351] trunk/Source/WebCore
Revision
260351
Author
[email protected]
Date
2020-04-19 23:20:07 -0700 (Sun, 19 Apr 2020)

Log Message

Remove unneeded code from FrameLoader::loadURL
https://bugs.webkit.org/show_bug.cgi?id=210696

Patch by Rob Buis <[email protected]> on 2020-04-19
Reviewed by Darin Adler.

Remove unneeded code from FrameLoader::loadURL, since the only way the load type can be Reload
is if loadFrameRequest set it, and the only way loadFrameRequest can set it is if cachePolicy
is ReloadIgnoringCacheData, so no need to set it again in FrameLoader::loadURL.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (260350 => 260351)


--- trunk/Source/WebCore/ChangeLog	2020-04-20 05:55:13 UTC (rev 260350)
+++ trunk/Source/WebCore/ChangeLog	2020-04-20 06:20:07 UTC (rev 260351)
@@ -1,3 +1,17 @@
+2020-04-19  Rob Buis  <[email protected]>
+
+        Remove unneeded code from FrameLoader::loadURL
+        https://bugs.webkit.org/show_bug.cgi?id=210696
+
+        Reviewed by Darin Adler.
+
+        Remove unneeded code from FrameLoader::loadURL, since the only way the load type can be Reload
+        is if loadFrameRequest set it, and the only way loadFrameRequest can set it is if cachePolicy
+        is ReloadIgnoringCacheData, so no need to set it again in FrameLoader::loadURL.
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::loadURL):
+
 2020-04-19  Brady Eidson  <[email protected]>
 
         Add WKScriptMessageHandler API that asynchronously responds with a promise.

Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (260350 => 260351)


--- trunk/Source/WebCore/loader/FrameLoader.cpp	2020-04-20 05:55:13 UTC (rev 260350)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2020-04-20 06:20:07 UTC (rev 260351)
@@ -1363,8 +1363,6 @@
         request.setHTTPReferrer(referrer);
 
     addExtraFieldsToRequest(request, IsMainResource::Yes, newLoadType);
-    if (isReload(newLoadType))
-        request.setCachePolicy(ResourceRequestCachePolicy::ReloadIgnoringCacheData);
 
     ASSERT(newLoadType != FrameLoadType::Same);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to