Title: [260354] trunk/Source/WebKit
- Revision
- 260354
- Author
- [email protected]
- Date
- 2020-04-20 00:11:28 -0700 (Mon, 20 Apr 2020)
Log Message
REGRESSION (r259610): Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc
<https://webkit.org/b/210711>
<rdar://problem/61993361>
Reviewed by Geoffrey Garen.
* UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKRBSAssertionDelegate dealloc]): Add.
- Release _invalidationCallback to fix the leak.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260353 => 260354)
--- trunk/Source/WebKit/ChangeLog 2020-04-20 06:32:49 UTC (rev 260353)
+++ trunk/Source/WebKit/ChangeLog 2020-04-20 07:11:28 UTC (rev 260354)
@@ -1,3 +1,15 @@
+2020-04-20 David Kilzer <[email protected]>
+
+ REGRESSION (r259610): Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc
+ <https://webkit.org/b/210711>
+ <rdar://problem/61993361>
+
+ Reviewed by Geoffrey Garen.
+
+ * UIProcess/ios/ProcessAssertionIOS.mm:
+ (-[WKRBSAssertionDelegate dealloc]): Add.
+ - Release _invalidationCallback to fix the leak.
+
2020-04-19 Brady Eidson <[email protected]>
Add WKScriptMessageHandler API that asynchronously responds with a promise.
Modified: trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm (260353 => 260354)
--- trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2020-04-20 06:32:49 UTC (rev 260353)
+++ trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2020-04-20 07:11:28 UTC (rev 260354)
@@ -272,6 +272,12 @@
@end
@implementation WKRBSAssertionDelegate
+- (void)dealloc
+{
+ [_invalidationCallback release];
+ [super dealloc];
+}
+
- (void)assertionWillInvalidate:(RBSAssertion *)assertion
{
RELEASE_LOG(ProcessSuspension, "%p - WKRBSAssertionDelegate: assertionWillInvalidate", self);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
