Title: [260386] trunk/Source/WebInspectorUI
- Revision
- 260386
- Author
- [email protected]
- Date
- 2020-04-20 12:35:22 -0700 (Mon, 20 Apr 2020)
Log Message
Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
https://bugs.webkit.org/show_bug.cgi?id=210679
Reviewed by Joseph Pecoraro.
* UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype.updateFilter):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (260385 => 260386)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-20 19:21:18 UTC (rev 260385)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-20 19:35:22 UTC (rev 260386)
@@ -1,5 +1,15 @@
2020-04-20 Devin Rousso <[email protected]>
+ Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
+ https://bugs.webkit.org/show_bug.cgi?id=210679
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WI.NavigationSidebarPanel.prototype.updateFilter):
+
+2020-04-20 Devin Rousso <[email protected]>
+
Web Inspector: removing a `WI.TreeElement` in a `WI.NavigationSidebar` doesn't check if the `WI.TreeOutline` still matches the current filter
https://bugs.webkit.org/show_bug.cgi?id=210672
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (260385 => 260386)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2020-04-20 19:21:18 UTC (rev 260385)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2020-04-20 19:35:22 UTC (rev 260386)
@@ -317,7 +317,7 @@
updateFilter()
{
let filters = this._filterBar.filters;
- this._textFilterRegex = simpleGlobStringToRegExp(filters.text, "i");
+ this._textFilterRegex = filters.text ? WI.SearchUtilities.filterRegExpForString(filters.text, WI.SearchUtilities.defaultSettings) : null;
this._filtersSetting.value = filters;
this._filterFunctions = filters.functions;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes