Title: [260421] trunk/JSTests
Revision
260421
Author
[email protected]
Date
2020-04-21 02:52:46 -0700 (Tue, 21 Apr 2020)

Log Message

Re-enable previously skipped mips tests
https://bugs.webkit.org/show_bug.cgi?id=209964

Patch by Paulo Matos <[email protected]> on 2020-04-21
Reviewed by Mark Lam.

Followup to r259454 - where we re-enabled a few stress tests for arm.

* stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
* stress/dont-range-based-iterate-vector-that-is-mutated.js:
* stress/ensure-code-block-is-not-precise-allocation.js:
* stress/generator-cell-with-type.js:
* stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
* stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
* stress/toctou-having-a-bad-time-new-array.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (260420 => 260421)


--- trunk/JSTests/ChangeLog	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/ChangeLog	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,3 +1,20 @@
+2020-04-21  Paulo Matos  <[email protected]>
+
+        Re-enable previously skipped mips tests
+        https://bugs.webkit.org/show_bug.cgi?id=209964
+
+        Reviewed by Mark Lam.
+
+        Followup to r259454 - where we re-enabled a few stress tests for arm.
+
+        * stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
+        * stress/dont-range-based-iterate-vector-that-is-mutated.js:
+        * stress/ensure-code-block-is-not-precise-allocation.js:
+        * stress/generator-cell-with-type.js:
+        * stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
+        * stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
+        * stress/toctou-having-a-bad-time-new-array.js:
+
 2020-04-20  Yusuke Suzuki  <[email protected]>
 
         [JSC] Import V8 BigInt tests generated by bigint-tester.py

Modified: trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js (260420 => 260421)


--- trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,4 +1,3 @@
-//@ skip if ["mips"].include?($architecture)
 //@ slow!
 //@ runDefault("--jitPolicyScale=0")
 

Modified: trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js (260420 => 260421)


--- trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,4 +1,3 @@
-//@ skip if not $jitTests and $architecture =~ /mips/ and $hostOS == "linux"
 // Should not crash when run with ASAN.
 
 function foo(arr1, arr2) {

Modified: trunk/JSTests/stress/ensure-code-block-is-not-precise-allocation.js (260420 => 260421)


--- trunk/JSTests/stress/ensure-code-block-is-not-precise-allocation.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/ensure-code-block-is-not-precise-allocation.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,4 +1,4 @@
-//@ if $architecture == "mips" then skip else slow! end
+//@ slow!
 // Does not crash.
 function foo() {
     +new Proxy({}, {get: foo});

Modified: trunk/JSTests/stress/generator-cell-with-type.js (260420 => 260421)


--- trunk/JSTests/stress/generator-cell-with-type.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/generator-cell-with-type.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,5 +1,8 @@
 // This test takes too long on mips devices.
-//@ skip if ["mips"].include?($architecture)
+//@ requireOptions("-e", "let iterations=1e5") if ["mips"].include?($architecture)
+
+iterations = typeof(iterations) === 'undefined' ? 1e6 : iterations;
+
 function shouldBe(actual, expected) {
     if (actual !== expected)
         throw new Error('bad value: ' + actual);
@@ -32,10 +35,10 @@
 }
 noInline(test);
 var gen = generator();
-for (var i = 0; i < 1e6; ++i)
+for (var i = 0; i < iterations; ++i)
     test(gen);
 
-for (var i = 0; i < 1e6; ++i) {
+for (var i = 0; i < iterations; ++i) {
     test(gen);
     shouldThrow(() => {
         test({

Modified: trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js (260420 => 260421)


--- trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,5 +1,4 @@
 //@ requireOptions("--jitPolicyScale=0")
-//@ skip if ["mips"].include?($architecture)
 //@ slow!
 
 for (let j = 0; j < 500; j++) {

Modified: trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js (260420 => 260421)


--- trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug" || ["mips"].include?($architecture)
+//@ skip if $buildType == "debug"
 //@ slow!
 //@ runDefault("--collectContinuously=1", "--slowPathAllocsBetweenGCs=100")
 

Modified: trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js (260420 => 260421)


--- trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-04-21 08:47:11 UTC (rev 260420)
+++ trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-04-21 09:52:46 UTC (rev 260421)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug" or ["mips"].include?($architecture)
+//@ skip if $buildType == "debug"
 
 let code = `
     function foo() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to