Title: [260474] trunk/Source/WebKit
- Revision
- 260474
- Author
- jer.no...@apple.com
- Date
- 2020-04-21 17:03:54 -0700 (Tue, 21 Apr 2020)
Log Message
PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=210813
Reviewed by Eric Carlson.
Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260473 => 260474)
--- trunk/Source/WebKit/ChangeLog 2020-04-21 23:12:29 UTC (rev 260473)
+++ trunk/Source/WebKit/ChangeLog 2020-04-22 00:03:54 UTC (rev 260474)
@@ -1,3 +1,16 @@
+2020-04-21 Jer Noble <jer.no...@apple.com>
+
+ PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
+ https://bugs.webkit.org/show_bug.cgi?id=210813
+
+ Reviewed by Eric Carlson.
+
+ Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
+ because that process is not a UI Application.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]):
+
2020-04-21 Brent Fulgham <bfulg...@apple.com>
[Cocoa] Don't bother compiling UpdateInfo since it's not used
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (260473 => 260474)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-04-21 23:12:29 UTC (rev 260473)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-04-22 00:03:54 UTC (rev 260474)
@@ -265,7 +265,7 @@
WebCore::PlaybackSessionModel* playbackSessionModel = playbackSessionInterface ? playbackSessionInterface->playbackSessionModel() : nullptr;
self.playing = playbackSessionModel ? playbackSessionModel->isPlaying() : NO;
- [_pipButton setHidden:!playbackSessionModel];
+ [_pipButton setHidden:!playbackSessionModel || !playbackSessionModel->isPictureInPictureSupported()];
}
- (void)setPrefersStatusBarHidden:(BOOL)value
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
