Title: [260502] trunk/Source/WebInspectorUI
- Revision
- 260502
- Author
- drou...@apple.com
- Date
- 2020-04-21 21:27:28 -0700 (Tue, 21 Apr 2020)
Log Message
Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
https://bugs.webkit.org/show_bug.cgi?id=210838
Reviewed by Joseph Pecoraro.
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
Include `WI.ShaderProgram` in the list of displayable represented objects.
* UserInterface/Base/Main.js:
(WI.tabContentViewClassForRepresentedObject):
* UserInterface/Views/GraphicsTabContentView.js:
(WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
Update the list of represented objects that are displayable by the Graphics Tab.
* UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview > section > .header):
(.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
Drive-by: add a top border to the first section when overscrolling.
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (260501 => 260502)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-22 04:27:28 UTC (rev 260502)
@@ -1,3 +1,29 @@
+2020-04-21 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=210838
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/CanvasSidebarPanel.js:
+ (WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
+ Include `WI.ShaderProgram` in the list of displayable represented objects.
+
+ * UserInterface/Base/Main.js:
+ (WI.tabContentViewClassForRepresentedObject):
+ * UserInterface/Views/GraphicsTabContentView.js:
+ (WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
+ Update the list of represented objects that are displayable by the Graphics Tab.
+
+ * UserInterface/Views/GraphicsOverviewContentView.css:
+ (.content-view.graphics-overview > section > .header):
+ (.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
+ Drive-by: add a top border to the first section when overscrolling.
+
+ * UserInterface/Views/CanvasOverviewContentView.css:
+ (.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
+ Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.
+
2020-04-20 Devin Rousso <drou...@apple.com>
Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (260501 => 260502)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-04-22 04:27:28 UTC (rev 260502)
@@ -1397,7 +1397,12 @@
|| representedObject instanceof WI.AuditTestCaseResult || representedObject instanceof WI.AuditTestGroupResult)
return WI.AuditTabContentView;
- if (representedObject instanceof WI.Canvas || representedObject instanceof WI.ShaderProgram || representedObject instanceof WI.Recording || representedObject instanceof WI.Animation)
+ if (representedObject instanceof WI.CanvasCollection
+ || representedObject instanceof WI.Canvas
+ || representedObject instanceof WI.Recording
+ || representedObject instanceof WI.ShaderProgram
+ || representedObject instanceof WI.AnimationCollection
+ || representedObject instanceof WI.Animation)
return WI.GraphicsTabContentView;
return null;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css (260501 => 260502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css 2020-04-22 04:27:28 UTC (rev 260502)
@@ -144,6 +144,7 @@
.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view {
position: static;
+ z-index: 0;
}
.content-view.canvas-overview > .content-view.canvas > footer {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (260501 => 260502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2020-04-22 04:27:28 UTC (rev 260502)
@@ -238,6 +238,7 @@
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WI.Canvas
+ || representedObject instanceof WI.ShaderProgram
|| representedObject instanceof WI.Recording;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css (260501 => 260502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css 2020-04-22 04:27:28 UTC (rev 260502)
@@ -43,18 +43,16 @@
display: flex;
align-items: center;
position: sticky;
- top: 0;
+ top: -1px;
z-index: 1;
min-height: var(--navigation-bar-height);
+ margin-top: -1px;
-webkit-padding-start: 8px;
background-color: hsl(0, 0%, 97%);
+ border-top: 1px solid var(--border-color);
border-bottom: 1px solid var(--border-color);
}
-.content-view.graphics-overview > section:not(:first-of-type) > .header {
- border-top: 1px solid var(--border-color);
-}
-
.content-view.graphics-overview > section > .header > h1 {
margin: 0;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js (260501 => 260502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js 2020-04-22 04:19:57 UTC (rev 260501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js 2020-04-22 04:27:28 UTC (rev 260502)
@@ -112,9 +112,7 @@
{
return representedObject instanceof WI.CanvasCollection
|| representedObject instanceof WI.Canvas
- || representedObject instanceof WI.RecordingCollection
|| representedObject instanceof WI.Recording
- || representedObject instanceof WI.ShaderProgramCollection
|| representedObject instanceof WI.ShaderProgram
|| representedObject instanceof WI.AnimationCollection
|| representedObject instanceof WI.Animation;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
