Title: [260519] branches/safari-609.2.9.0-branch/Source/WebKit
- Revision
- 260519
- Author
- [email protected]
- Date
- 2020-04-22 10:17:43 -0700 (Wed, 22 Apr 2020)
Log Message
Cherry-pick r260474. rdar://problem/62083321
PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=210813
Reviewed by Eric Carlson.
Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609.2.9.0-branch/Source/WebKit/ChangeLog (260518 => 260519)
--- branches/safari-609.2.9.0-branch/Source/WebKit/ChangeLog 2020-04-22 16:56:00 UTC (rev 260518)
+++ branches/safari-609.2.9.0-branch/Source/WebKit/ChangeLog 2020-04-22 17:17:43 UTC (rev 260519)
@@ -1,3 +1,19 @@
+2020-04-22 Russell Epstein <[email protected]>
+
+ Cherry-pick r260474. rdar://problem/62083321.
+
+ 2020-04-21 Jer Noble <[email protected]>
+
+ PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
+ https://bugs.webkit.org/show_bug.cgi?id=210813
+
+ Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
+ because that process is not a UI Application.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]):
+
+
2020-04-21 Alan Coon <[email protected]>
Apply patch. rdar://problem/62083319
Modified: branches/safari-609.2.9.0-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (260518 => 260519)
--- branches/safari-609.2.9.0-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-04-22 16:56:00 UTC (rev 260518)
+++ branches/safari-609.2.9.0-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-04-22 17:17:43 UTC (rev 260519)
@@ -265,7 +265,7 @@
WebCore::PlaybackSessionModel* playbackSessionModel = playbackSessionInterface ? playbackSessionInterface->playbackSessionModel() : nullptr;
self.playing = playbackSessionModel ? playbackSessionModel->isPlaying() : NO;
- [_pipButton setHidden:!playbackSessionModel];
+ [_pipButton setHidden:!playbackSessionModel || !playbackSessionModel->isPictureInPictureSupported()];
}
- (void)setPrefersStatusBarHidden:(BOOL)value
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
