Title: [260530] trunk/Tools
- Revision
- 260530
- Author
- [email protected]
- Date
- 2020-04-22 13:07:19 -0700 (Wed, 22 Apr 2020)
Log Message
TextManipulation.CompleteTextManipulationAvoidCrashingWhenContentIsRemoved does not wait for result
https://bugs.webkit.org/show_bug.cgi?id=210871
Reviewed by Alex Christensen.
* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (260529 => 260530)
--- trunk/Tools/ChangeLog 2020-04-22 19:38:00 UTC (rev 260529)
+++ trunk/Tools/ChangeLog 2020-04-22 20:07:19 UTC (rev 260530)
@@ -1,3 +1,13 @@
+2020-04-22 Sihui Liu <[email protected]>
+
+ TextManipulation.CompleteTextManipulationAvoidCrashingWhenContentIsRemoved does not wait for result
+ https://bugs.webkit.org/show_bug.cgi?id=210871
+
+ Reviewed by Alex Christensen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
+ (TestWebKitAPI::TEST):
+
2020-04-22 Alex Christensen <[email protected]>
Add unit test for resuming downloads
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm (260529 => 260530)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-04-22 19:38:00 UTC (rev 260529)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-04-22 20:07:19 UTC (rev 260530)
@@ -872,6 +872,7 @@
"paragraph.textContent = 'Hello world';"
"document.body.appendChild(paragraph);"
"setTimeout(() => { paragraph.remove(); webkit.messageHandlers.testHandler.postMessage('DoneRemovingParagraph') })"];
+ TestWebKitAPI::Util::run(&done);
done = false;
[webView _completeTextManipulationForItems:@[(_WKTextManipulationItem *)createItem(items[0].identifier, {
@@ -880,6 +881,7 @@
EXPECT_EQ(errors, nil);
done = true;
}];
+ TestWebKitAPI::Util::run(&done);
EXPECT_WK_STREQ("Simple HTML file!", [webView stringByEvaluatingJavaScript:@"document.body.textContent"]);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
