Title: [260608] trunk/Source/WebKit
- Revision
- 260608
- Author
- [email protected]
- Date
- 2020-04-23 16:59:30 -0700 (Thu, 23 Apr 2020)
Log Message
Long pressing attachments in Notes does not activate Context Menu.
https://bugs.webkit.org/show_bug.cgi?id=210936
<rdar://problem/61171576>
Reviewed by Tim Horton.
Not having the ID available for notes makes their code to create the context
menu and its items fail. We should probably be passing this information on
for any element if we have it.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionPositionInformation):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260607 => 260608)
--- trunk/Source/WebKit/ChangeLog 2020-04-23 23:54:09 UTC (rev 260607)
+++ trunk/Source/WebKit/ChangeLog 2020-04-23 23:59:30 UTC (rev 260608)
@@ -1,3 +1,18 @@
+2020-04-23 Megan Gardner <[email protected]>
+
+ Long pressing attachments in Notes does not activate Context Menu.
+ https://bugs.webkit.org/show_bug.cgi?id=210936
+ <rdar://problem/61171576>
+
+ Reviewed by Tim Horton.
+
+ Not having the ID available for notes makes their code to create the context
+ menu and its items fail. We should probably be passing this information on
+ for any element if we have it.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::selectionPositionInformation):
+
2020-04-23 Brent Fulgham <[email protected]>
Allow "kern.osversion" sysctl read
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (260607 => 260608)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-04-23 23:54:09 UTC (rev 260607)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-04-23 23:59:30 UTC (rev 260608)
@@ -2788,6 +2788,12 @@
RenderObject* renderer = hitNode->renderer();
info.bounds = renderer->absoluteBoundingBoxRect(true);
+
+ if (is<Element>(*hitNode)) {
+ Element& element = downcast<Element>(*hitNode);
+ info.idAttribute = element.getIdAttribute();
+ }
+
if (is<HTMLAttachmentElement>(*hitNode)) {
info.isAttachment = true;
HTMLAttachmentElement& attachment = downcast<HTMLAttachmentElement>(*hitNode);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
