Title: [260617] trunk/Tools
- Revision
- 260617
- Author
- [email protected]
- Date
- 2020-04-23 20:31:10 -0700 (Thu, 23 Apr 2020)
Log Message
Disable useKernTCSM=false for JSC stress tests to make EWS faster
https://bugs.webkit.org/show_bug.cgi?id=210950
Reviewed by Mark Lam.
This patch removes "JSC_useKernTCSM=false" environment variable in JSC stress tests.
Alexey found that this causes EWS JSC stress tests slow down (from roughly 63 mins to 83 mins).
This slow down happens in Mac Pro (which is used in JSC EWS right now), and this slow down does
not happen in Mac mini (post-commit buildbot) and rather improves Mac Mini execution time by 15%,
but keeping EWS faster is more important than making post-commit bots faster.
* Scripts/run-_javascript_core-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (260616 => 260617)
--- trunk/Tools/ChangeLog 2020-04-24 01:14:00 UTC (rev 260616)
+++ trunk/Tools/ChangeLog 2020-04-24 03:31:10 UTC (rev 260617)
@@ -1,5 +1,20 @@
2020-04-23 Yusuke Suzuki <[email protected]>
+ Disable useKernTCSM=false for JSC stress tests to make EWS faster
+ https://bugs.webkit.org/show_bug.cgi?id=210950
+
+ Reviewed by Mark Lam.
+
+ This patch removes "JSC_useKernTCSM=false" environment variable in JSC stress tests.
+ Alexey found that this causes EWS JSC stress tests slow down (from roughly 63 mins to 83 mins).
+ This slow down happens in Mac Pro (which is used in JSC EWS right now), and this slow down does
+ not happen in Mac mini (post-commit buildbot) and rather improves Mac Mini execution time by 15%,
+ but keeping EWS faster is more important than making post-commit bots faster.
+
+ * Scripts/run-_javascript_core-tests:
+
+2020-04-23 Yusuke Suzuki <[email protected]>
+
Support `--report-execution-time` to report execution time for each JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=210938
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (260616 => 260617)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2020-04-24 01:14:00 UTC (rev 260616)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2020-04-24 03:31:10 UTC (rev 260617)
@@ -527,10 +527,6 @@
}
}
-if (isAppleMacWebKit()) {
- $envVars .= " JSC_useKernTCSM=false";
-}
-
my $productDir = jscProductDir();
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
$ENV{JSCTEST_timeout} = 120 unless $ENV{JSCTEST_timeout}; # Set a 120 second timeout on all jsc tests (if environment variable not defined already).
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
