Title: [260638] trunk/LayoutTests
- Revision
- 260638
- Author
- [email protected]
- Date
- 2020-04-24 03:35:56 -0700 (Fri, 24 Apr 2020)
Log Message
getDisplayMedia is not respecting aspect ratio with max constraints
https://bugs.webkit.org/show_bug.cgi?id=210858
<rdar://problem/61405434>
Unreviewed.
Remove these tests as it is redundant with getDisplayMedia-max-constraints 1 2 and 3.
* fast/mediastream/getDisplayMedia-max-constraints-expected.txt: Removed.
* fast/mediastream/getDisplayMedia-max-constraints.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (260637 => 260638)
--- trunk/LayoutTests/ChangeLog 2020-04-24 09:58:13 UTC (rev 260637)
+++ trunk/LayoutTests/ChangeLog 2020-04-24 10:35:56 UTC (rev 260638)
@@ -1,3 +1,15 @@
+2020-04-24 Youenn Fablet <[email protected]>
+
+ getDisplayMedia is not respecting aspect ratio with max constraints
+ https://bugs.webkit.org/show_bug.cgi?id=210858
+ <rdar://problem/61405434>
+
+ Unreviewed.
+ Remove these tests as it is redundant with getDisplayMedia-max-constraints 1 2 and 3.
+
+ * fast/mediastream/getDisplayMedia-max-constraints-expected.txt: Removed.
+ * fast/mediastream/getDisplayMedia-max-constraints.html: Removed.
+
2020-04-24 Diego Pino Garcia <[email protected]>
[WPE] Gardening, expected to fail but passing
Deleted: trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints-expected.txt (260637 => 260638)
--- trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints-expected.txt 2020-04-24 09:58:13 UTC (rev 260637)
+++ trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints-expected.txt 2020-04-24 10:35:56 UTC (rev 260638)
@@ -1,6 +0,0 @@
-
-PASS setup
-PASS Maximize the width if max height is too big
-PASS Maximize the height if max width is too big
-PASS No effect of the max values if they are too big
-
Deleted: trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints.html (260637 => 260638)
--- trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints.html 2020-04-24 09:58:13 UTC (rev 260637)
+++ trunk/LayoutTests/fast/mediastream/getDisplayMedia-max-constraints.html 2020-04-24 10:35:56 UTC (rev 260638)
@@ -1,93 +0,0 @@
-<!doctype html>
-<html>
- <head>
- <meta charset="utf-8">
- <title>getDisplayMedia track support of max constraints</title>
- <script src=""
- <script src=""
- </head>
- <body>
-
- <script>
- if (window.internals)
- window.internals.settings.setScreenCaptureEnabled(true);
-
- async function callGetDisplayMedia(options)
- {
- let promise;
- window.internals.withUserGesture(() => {
- promise = navigator.mediaDevices.getDisplayMedia(options);
- });
- const stream = await promise;
- const track = stream.getVideoTracks()[0];
-
- // getSettings is not computing the correct parameters right away. We should probably fix this.
- while (true) {
- const settings = track.getSettings();
- if (settings.width && settings.height)
- break;
- await new Promise(resolve => setTimeout(resolve, 50));
- }
- return stream;
- }
-
- // getSettings is not computing the correct parameters right away. We should probably fix this.
- async function waitForHeight(track, value) {
- while (true) {
- const settings = track.getSettings();
- if (settings.height === value)
- break;
- await new Promise(resolve => setTimeout(resolve, 50));
- }
- }
-
- // getSettings is not computing the correct parameters right away. We should probably fix this.
- async function waitForWidth(track, value) {
- while (true) {
- const settings = track.getSettings();
- if (settings.width === value)
- break;
- await new Promise(resolve => setTimeout(resolve, 50));
- }
- }
-
- let defaultWidth;
- let defaultHeight;
- promise_test(async () => {
- stream = await callGetDisplayMedia({ video: true });
- let settings = stream.getVideoTracks()[0].getSettings();
- defaultWidth = settings.width;
- defaultHeight = settings.height;
- }, "setup");
-
- promise_test(async (test) => {
- const stream = await callGetDisplayMedia({ video: { height: { max: 500 }, width : { max : 500 } } });
-
- const expectedHeight =Math.floor(500 * (defaultHeight / defaultWidth))
- await waitForHeight(stream.getVideoTracks()[0], expectedHeight);
-
- const settings = stream.getVideoTracks()[0].getSettings()
- assert_equals(settings.width, 500);
- }, "Maximize the width if max height is too big");
-
- promise_test(async (test) => {
- const stream = await callGetDisplayMedia({ video: { height: { max: 100 }, width : { max : 500 } } });
-
- const expectedWidth = Math.floor(100 * (defaultWidth / defaultHeight))
- await waitForWidth(stream.getVideoTracks()[0], expectedWidth);
-
- const settings = stream.getVideoTracks()[0].getSettings()
- assert_equals(settings.height, 100);
- }, "Maximize the height if max width is too big");
-
- promise_test(async (test) => {
- const stream = await callGetDisplayMedia({ video: { height: { max: 500000 }, width : { max : 500000 } } });
-
- await waitForHeight(stream.getVideoTracks()[0], defaultHeight);
-
- const settings = stream.getVideoTracks()[0].getSettings()
- assert_equals(settings.width, defaultWidth);
- }, "No effect of the max values if they are too big");
- </script>
- </body>
-</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
