Title: [260664] trunk/Source/_javascript_Core
Revision
260664
Author
[email protected]
Date
2020-04-24 13:11:04 -0700 (Fri, 24 Apr 2020)

Log Message

Unreviewed, build fix in Windows
https://bugs.webkit.org/show_bug.cgi?id=210892

Windows MSVC does not have proper understanding of IGNORE_RETURN_TYPE_WARNINGS_BEGIN.

* runtime/JSBigInt.h:
(JSC::invertBigIntCompareResult):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (260663 => 260664)


--- trunk/Source/_javascript_Core/ChangeLog	2020-04-24 20:05:57 UTC (rev 260663)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-04-24 20:11:04 UTC (rev 260664)
@@ -1,5 +1,15 @@
 2020-04-24  Yusuke Suzuki  <[email protected]>
 
+        Unreviewed, build fix in Windows
+        https://bugs.webkit.org/show_bug.cgi?id=210892
+
+        Windows MSVC does not have proper understanding of IGNORE_RETURN_TYPE_WARNINGS_BEGIN.
+
+        * runtime/JSBigInt.h:
+        (JSC::invertBigIntCompareResult):
+
+2020-04-24  Yusuke Suzuki  <[email protected]>
+
         [JSC] DFG compare should speculate BigInt well
         https://bugs.webkit.org/show_bug.cgi?id=210892
 

Modified: trunk/Source/_javascript_Core/runtime/JSBigInt.h (260663 => 260664)


--- trunk/Source/_javascript_Core/runtime/JSBigInt.h	2020-04-24 20:05:57 UTC (rev 260663)
+++ trunk/Source/_javascript_Core/runtime/JSBigInt.h	2020-04-24 20:11:04 UTC (rev 260664)
@@ -290,9 +290,6 @@
     dataStorage()[n] = value;
 }
 
-#if !ASSERT_ENABLED
-IGNORE_RETURN_TYPE_WARNINGS_BEGIN
-#endif
 ALWAYS_INLINE JSBigInt::ComparisonResult invertBigIntCompareResult(JSBigInt::ComparisonResult comparisonResult)
 {
     switch (comparisonResult) {
@@ -300,14 +297,9 @@
         return JSBigInt::ComparisonResult::LessThan;
     case JSBigInt::ComparisonResult::LessThan:
         return JSBigInt::ComparisonResult::GreaterThan;
-    case JSBigInt::ComparisonResult::Equal:
-    case JSBigInt::ComparisonResult::Undefined:
+    default:
         return comparisonResult;
     }
-    ASSERT_NOT_REACHED();
 }
-#if !ASSERT_ENABLED
-IGNORE_RETURN_TYPE_WARNINGS_END
-#endif
 
 } // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to