Title: [260669] trunk/Source/WebCore
- Revision
- 260669
- Author
- [email protected]
- Date
- 2020-04-24 14:11:01 -0700 (Fri, 24 Apr 2020)
Log Message
ASSERTION FAILED: m_wrapper under HTMLMediaElement::setIsPlayingToWirelessTarget
https://bugs.webkit.org/show_bug.cgi?id=210983
<rdar://problem/61611994>
Reviewed by Eric Carlson.
The issue was that we were trying to fire a JS event as a result of ActiveDOMObject::stop()
getting called, which is not allowed. To address the issue, we avoid firing the event if
the context is already stopped.
No new tests, already covered by:
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (260668 => 260669)
--- trunk/Source/WebCore/ChangeLog 2020-04-24 21:08:10 UTC (rev 260668)
+++ trunk/Source/WebCore/ChangeLog 2020-04-24 21:11:01 UTC (rev 260669)
@@ -1,3 +1,21 @@
+2020-04-24 Chris Dumez <[email protected]>
+
+ ASSERTION FAILED: m_wrapper under HTMLMediaElement::setIsPlayingToWirelessTarget
+ https://bugs.webkit.org/show_bug.cgi?id=210983
+ <rdar://problem/61611994>
+
+ Reviewed by Eric Carlson.
+
+ The issue was that we were trying to fire a JS event as a result of ActiveDOMObject::stop()
+ getting called, which is not allowed. To address the issue, we avoid firing the event if
+ the context is already stopped.
+
+ No new tests, already covered by:
+ media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):
+
2020-04-24 Tim Horton <[email protected]>
iPad: "Pocket City" interaction does not work with trackpad
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (260668 => 260669)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-04-24 21:08:10 UTC (rev 260668)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-04-24 21:11:01 UTC (rev 260669)
@@ -5798,7 +5798,8 @@
m_failedToPlayToWirelessTarget = false;
scheduleCheckPlaybackTargetCompatability();
- dispatchEvent(Event::create(eventNames().webkitcurrentplaybacktargetiswirelesschangedEvent, Event::CanBubble::No, Event::IsCancelable::Yes));
+ if (!isContextStopped())
+ dispatchEvent(Event::create(eventNames().webkitcurrentplaybacktargetiswirelesschangedEvent, Event::CanBubble::No, Event::IsCancelable::Yes));
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
