Title: [260715] trunk/Source/WTF
Revision
260715
Author
[email protected]
Date
2020-04-25 18:01:52 -0700 (Sat, 25 Apr 2020)

Log Message

Unreviewed. Remove the bulid warnings below since r260707.
warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]

* wtf/URL.cpp:
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (260714 => 260715)


--- trunk/Source/WTF/ChangeLog	2020-04-26 00:31:57 UTC (rev 260714)
+++ trunk/Source/WTF/ChangeLog	2020-04-26 01:01:52 UTC (rev 260715)
@@ -1,3 +1,14 @@
+2020-04-25  Joonghun Park  <[email protected]>
+
+        Unreviewed. Remove the bulid warnings below since r260707.
+        warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
+
+        * wtf/URL.cpp:
+        (WTF::URL::setHost):
+        (WTF::URL::setHostAndPort):
+        (WTF::URL::setUser):
+        (WTF::URL::setPassword):
+
 2020-04-25  Darin Adler  <[email protected]>
 
         [Cocoa] Deal with another round of Xcode upgrade checks

Modified: trunk/Source/WTF/wtf/URL.cpp (260714 => 260715)


--- trunk/Source/WTF/wtf/URL.cpp	2020-04-26 00:31:57 UTC (rev 260714)
+++ trunk/Source/WTF/wtf/URL.cpp	2020-04-26 01:01:52 UTC (rev 260715)
@@ -436,7 +436,7 @@
     if (!appendEncodedHostname(encodedHostName, newHost))
         return;
 
-    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
     parse(makeString(
         StringView(m_string).left(hostStart()),
         slashSlashNeeded ? "//" : "",
@@ -486,7 +486,7 @@
     if (!appendEncodedHostname(encodedHostName, hostName))
         return;
 
-    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
     parse(makeString(
         StringView(m_string).left(hostStart()),
         slashSlashNeeded ? "//" : "",
@@ -547,7 +547,7 @@
 
     unsigned end = m_userEnd;
     if (!newUser.isEmpty()) {
-        bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+        bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
         bool needSeparator = end == m_hostEnd || (end == m_passwordEnd && m_string[end] != '@');
         parse(makeString(
             StringView(m_string).left(m_userStart),
@@ -570,7 +570,7 @@
         return;
 
     if (!newPassword.isEmpty()) {
-        bool needLeadingSlashes = m_userEnd == m_schemeEnd + 1;
+        bool needLeadingSlashes = m_userEnd == static_cast<unsigned>(m_schemeEnd + 1);
         parse(makeString(
             StringView(m_string).left(m_userEnd),
             needLeadingSlashes ? "//:" : ":",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to