Diff
Modified: trunk/Source/WebCore/ChangeLog (260728 => 260729)
--- trunk/Source/WebCore/ChangeLog 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/ChangeLog 2020-04-26 20:02:18 UTC (rev 260729)
@@ -1,3 +1,18 @@
+2020-04-26 Peng Liu <peng.l...@apple.com>
+
+ Remove unused class PlaybackSessionInterface
+ https://bugs.webkit.org/show_bug.cgi?id=211031
+
+ Reviewed by Daniel Bates.
+
+ No new tests, no functional changes.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/cocoa/PlaybackSessionInterface.h: Removed.
+ * platform/cocoa/PlaybackSessionModelMediaElement.h:
+ * platform/ios/PlaybackSessionInterfaceAVKit.h:
+ * platform/mac/PlaybackSessionInterfaceMac.h:
+
2020-04-26 Zalan Bujtas <za...@apple.com>
[LFC][TFC] Compute and distribute extra vertical space for rows
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (260728 => 260729)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-04-26 20:02:18 UTC (rev 260729)
@@ -4158,7 +4158,6 @@
CD9DE17B17AAC75B00EA386D /* JSSourceBuffer.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9DE17717AAC75B00EA386D /* JSSourceBuffer.h */; };
CD9DE17D17AAC75B00EA386D /* JSSourceBufferList.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9DE17917AAC75B00EA386D /* JSSourceBufferList.h */; };
CD9DE18217AAD6A400EA386D /* DOMURLMediaSource.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9DE17F17AAD64E00EA386D /* DOMURLMediaSource.h */; };
- CDA29A091CBD99F400901CCF /* PlaybackSessionInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA29A081CBD99F400901CCF /* PlaybackSessionInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDA29A0B1CBD9A7400901CCF /* PlaybackSessionModel.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA29A0A1CBD9A7400901CCF /* PlaybackSessionModel.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDA29A0F1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA29A0D1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDA29A161CBDA56C00901CCF /* PlaybackSessionInterfaceMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDA29A141CBDA56C00901CCF /* PlaybackSessionInterfaceMac.mm */; };
@@ -14073,7 +14072,6 @@
CD9DE18017AAD64E00EA386D /* DOMURLMediaSource.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = DOMURLMediaSource.idl; sourceTree = "<group>"; };
CDA130BB1FEB332C00F53254 /* NavigatorMediaCapabilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NavigatorMediaCapabilities.cpp; sourceTree = "<group>"; };
CDA130BD1FEB332D00F53254 /* MediaCapabilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaCapabilities.cpp; sourceTree = "<group>"; };
- CDA29A081CBD99F400901CCF /* PlaybackSessionInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlaybackSessionInterface.h; sourceTree = "<group>"; };
CDA29A0A1CBD9A7400901CCF /* PlaybackSessionModel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlaybackSessionModel.h; sourceTree = "<group>"; };
CDA29A0C1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = PlaybackSessionModelMediaElement.mm; sourceTree = "<group>"; };
CDA29A0D1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlaybackSessionModelMediaElement.h; sourceTree = "<group>"; };
@@ -23400,7 +23398,6 @@
F4FB35002350C96200F0094A /* PasteboardCustomDataCocoa.mm */,
F4628A9E234D3BBF00BC884C /* PlatformPasteboardCocoa.mm */,
52B0D4BD1C57FD1E0077CE53 /* PlatformView.h */,
- CDA29A081CBD99F400901CCF /* PlaybackSessionInterface.h */,
CDA29A0A1CBD9A7400901CCF /* PlaybackSessionModel.h */,
CDA29A0D1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.h */,
CDA29A0C1CBD9CFE00901CCF /* PlaybackSessionModelMediaElement.mm */,
@@ -32323,7 +32320,6 @@
935C476B09AC4D4F00A6AAB4 /* PlatformWheelEvent.h in Headers */,
E1EE8B722412B2A800E794D6 /* PlatformXR.h in Headers */,
712BE4801FE864A7002031CC /* PlaybackDirection.h in Headers */,
- CDA29A091CBD99F400901CCF /* PlaybackSessionInterface.h in Headers */,
CDA29A321CC01A9500901CCF /* PlaybackSessionInterfaceAVKit.h in Headers */,
CDA29A171CBDA56C00901CCF /* PlaybackSessionInterfaceMac.h in Headers */,
CDA29A0B1CBD9A7400901CCF /* PlaybackSessionModel.h in Headers */,
Deleted: trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h (260728 => 260729)
--- trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2020-04-26 20:02:18 UTC (rev 260729)
@@ -1,45 +0,0 @@
-/*
- * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
-
-#include <wtf/Forward.h>
-#include <wtf/Vector.h>
-
-namespace WebCore {
-
-class TimeRanges;
-
-class PlaybackSessionInterface {
-public:
- virtual ~PlaybackSessionInterface() { };
-};
-
-}
-
-#endif // PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
-
Modified: trunk/Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h (260728 => 260729)
--- trunk/Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h 2020-04-26 20:02:18 UTC (rev 260729)
@@ -39,7 +39,6 @@
class AudioTrack;
class HTMLMediaElement;
class TextTrack;
-class PlaybackSessionInterface;
class PlaybackSessionModelMediaElement final : public PlaybackSessionModel, public EventListener {
public:
Modified: trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h (260728 => 260729)
--- trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2020-04-26 20:02:18 UTC (rev 260729)
@@ -30,7 +30,6 @@
#include "EventListener.h"
#include "HTMLMediaElementEnums.h"
-#include "PlaybackSessionInterface.h"
#include "PlaybackSessionModel.h"
#include "Timer.h"
#include <functional>
@@ -48,8 +47,7 @@
class WebPlaybackSessionChangeObserver;
class WEBCORE_EXPORT PlaybackSessionInterfaceAVKit
- : public PlaybackSessionInterface
- , public PlaybackSessionModelClient
+ : public PlaybackSessionModelClient
, public RefCounted<PlaybackSessionInterfaceAVKit> {
public:
Modified: trunk/Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h (260728 => 260729)
--- trunk/Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h 2020-04-26 20:02:18 UTC (rev 260729)
@@ -28,7 +28,6 @@
#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
#include "HTMLMediaElementEnums.h"
-#include "PlaybackSessionInterface.h"
#include "PlaybackSessionModel.h"
#include <wtf/RefCounted.h>
#include <wtf/RetainPtr.h>
@@ -43,8 +42,7 @@
class PlaybackSessionModel;
class WEBCORE_EXPORT PlaybackSessionInterfaceMac final
- : public PlaybackSessionInterface
- , public PlaybackSessionModelClient
+ : public PlaybackSessionModelClient
, public RefCounted<PlaybackSessionInterfaceMac> {
public:
static Ref<PlaybackSessionInterfaceMac> create(PlaybackSessionModel&);
Modified: trunk/Source/WebKit/ChangeLog (260728 => 260729)
--- trunk/Source/WebKit/ChangeLog 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebKit/ChangeLog 2020-04-26 20:02:18 UTC (rev 260729)
@@ -1,3 +1,12 @@
+2020-04-26 Peng Liu <peng.l...@apple.com>
+
+ Remove unused class PlaybackSessionInterface
+ https://bugs.webkit.org/show_bug.cgi?id=211031
+
+ Reviewed by Daniel Bates.
+
+ * WebProcess/cocoa/PlaybackSessionManager.h:
+
2020-04-11 Darin Adler <da...@apple.com>
Stop using live ranges in functions that return range of the selection
Modified: trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h (260728 => 260729)
--- trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h 2020-04-26 19:51:38 UTC (rev 260728)
+++ trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h 2020-04-26 20:02:18 UTC (rev 260729)
@@ -31,7 +31,6 @@
#include <WebCore/EventListener.h>
#include <WebCore/HTMLMediaElementEnums.h>
#include <WebCore/PlatformCALayer.h>
-#include <WebCore/PlaybackSessionInterface.h>
#include <WebCore/PlaybackSessionModelMediaElement.h>
#include <wtf/HashCountedSet.h>
#include <wtf/HashMap.h>
@@ -56,7 +55,6 @@
class PlaybackSessionInterfaceContext final
: public RefCounted<PlaybackSessionInterfaceContext>
- , public WebCore::PlaybackSessionInterface
, public WebCore::PlaybackSessionModelClient {
public:
static Ref<PlaybackSessionInterfaceContext> create(PlaybackSessionManager& manager, uint64_t contextId)
