Title: [260750] trunk/Source/WebCore
Revision
260750
Author
[email protected]
Date
2020-04-27 04:52:10 -0700 (Mon, 27 Apr 2020)

Log Message

[GTK] [2.28.0] The Yelp build crashes if DISPLAY is not set
https://bugs.webkit.org/show_bug.cgi?id=209431

Reviewed by Carlos Garcia Campos.

Don't create a PlatformDisplayLibWPE as a fallback when using
Wayland or X11.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (260749 => 260750)


--- trunk/Source/WebCore/ChangeLog	2020-04-27 10:45:32 UTC (rev 260749)
+++ trunk/Source/WebCore/ChangeLog	2020-04-27 11:52:10 UTC (rev 260750)
@@ -1,3 +1,16 @@
+2020-04-27  Alberto Garcia  <[email protected]>
+
+        [GTK] [2.28.0] The Yelp build crashes if DISPLAY is not set
+        https://bugs.webkit.org/show_bug.cgi?id=209431
+
+        Reviewed by Carlos Garcia Campos.
+
+        Don't create a PlatformDisplayLibWPE as a fallback when using
+        Wayland or X11.
+
+        * platform/graphics/PlatformDisplay.cpp:
+        (WebCore::PlatformDisplay::createPlatformDisplay):
+
 2020-04-27  Claudio Saavedra  <[email protected]>
 
         Unreviewed compile-warning fix.

Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp (260749 => 260750)


--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2020-04-27 10:45:32 UTC (rev 260749)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2020-04-27 11:52:10 UTC (rev 260750)
@@ -98,12 +98,6 @@
     }
 #endif // PLATFORM(GTK)
 
-#if USE(WPE_RENDERER)
-    return PlatformDisplayLibWPE::create();
-#elif PLATFORM(WIN)
-    return PlatformDisplayWin::create();
-#endif
-
 #if PLATFORM(WAYLAND)
     if (auto platformDisplay = PlatformDisplayWayland::create())
         return platformDisplay;
@@ -121,6 +115,12 @@
     return PlatformDisplayX11::create(nullptr);
 #endif
 
+#if USE(WPE_RENDERER)
+    return PlatformDisplayLibWPE::create();
+#elif PLATFORM(WIN)
+    return PlatformDisplayWin::create();
+#endif
+
     RELEASE_ASSERT_NOT_REACHED();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to