Title: [260846] trunk/Source/WebKit
- Revision
- 260846
- Author
- [email protected]
- Date
- 2020-04-28 14:31:34 -0700 (Tue, 28 Apr 2020)
Log Message
Remove unused WebPage::focusTextInputContext()
https://bugs.webkit.org/show_bug.cgi?id=211135
Reviewed by Anders Carlsson.
I accidentally forgot to remove the WebPage message and WebPage implementation that
backed -_focusTextInputContext when I removed it in r260225. Now the implementation
is unused. Let's remove it.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusTextInputContext): Deleted.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260845 => 260846)
--- trunk/Source/WebKit/ChangeLog 2020-04-28 21:15:33 UTC (rev 260845)
+++ trunk/Source/WebKit/ChangeLog 2020-04-28 21:31:34 UTC (rev 260846)
@@ -1,3 +1,19 @@
+2020-04-28 Daniel Bates <[email protected]>
+
+ Remove unused WebPage::focusTextInputContext()
+ https://bugs.webkit.org/show_bug.cgi?id=211135
+
+ Reviewed by Anders Carlsson.
+
+ I accidentally forgot to remove the WebPage message and WebPage implementation that
+ backed -_focusTextInputContext when I removed it in r260225. Now the implementation
+ is unused. Let's remove it.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::focusTextInputContext): Deleted.
+ * WebProcess/WebPage/WebPage.h:
+ * WebProcess/WebPage/WebPage.messages.in:
+
2020-04-28 Christopher Reid <[email protected]>
[Win] Bundle Inspector Resources in Release builds
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (260845 => 260846)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-04-28 21:15:33 UTC (rev 260845)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-04-28 21:31:34 UTC (rev 260846)
@@ -6932,16 +6932,6 @@
completionHandler(contexts);
}
-void WebPage::focusTextInputContext(const WebCore::ElementContext& textInputContext, CompletionHandler<void(bool)>&& completionHandler)
-{
- auto element = elementForContext(textInputContext);
-
- if (element)
- element->focus();
-
- completionHandler(element);
-}
-
void WebPage::setCanShowPlaceholder(const WebCore::ElementContext& elementContext, bool canShowPlaceholder)
{
RefPtr<Element> element = elementForContext(elementContext);
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (260845 => 260846)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2020-04-28 21:15:33 UTC (rev 260845)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2020-04-28 21:31:34 UTC (rev 260846)
@@ -645,7 +645,6 @@
void selectAll();
void textInputContextsInRect(WebCore::FloatRect, CompletionHandler<void(const Vector<WebCore::ElementContext>&)>&&);
- void focusTextInputContext(const WebCore::ElementContext&, CompletionHandler<void(bool)>&&);
void setCanShowPlaceholder(const WebCore::ElementContext&, bool);
#if PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (260845 => 260846)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2020-04-28 21:15:33 UTC (rev 260845)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2020-04-28 21:31:34 UTC (rev 260846)
@@ -578,7 +578,6 @@
#endif
TextInputContextsInRect(WebCore::FloatRect rect) -> (Vector<struct WebCore::ElementContext> contexts) Async
- FocusTextInputContext(struct WebCore::ElementContext context) -> (bool success) Async
SetCanShowPlaceholder(struct WebCore::ElementContext context, bool canShowPlaceholder)
#if ENABLE(RESOURCE_LOAD_STATISTICS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
