Title: [260886] trunk/Source/WebCore
- Revision
- 260886
- Author
- [email protected]
- Date
- 2020-04-29 01:14:06 -0700 (Wed, 29 Apr 2020)
Log Message
[GStreamer] Switch to audiointerleave
https://bugs.webkit.org/show_bug.cgi?id=211124
Patch by Philippe Normand <[email protected]> on 2020-04-29
Reviewed by Xabier Rodriguez-Calvar.
The audiointerleave element is a drop-in replacement of
interleave. It should behave a bit better in live.
No new tests, existing webaudio tests cover this change.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcChangeState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (260885 => 260886)
--- trunk/Source/WebCore/ChangeLog 2020-04-29 07:59:17 UTC (rev 260885)
+++ trunk/Source/WebCore/ChangeLog 2020-04-29 08:14:06 UTC (rev 260886)
@@ -1,3 +1,19 @@
+2020-04-29 Philippe Normand <[email protected]>
+
+ [GStreamer] Switch to audiointerleave
+ https://bugs.webkit.org/show_bug.cgi?id=211124
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ The audiointerleave element is a drop-in replacement of
+ interleave. It should behave a bit better in live.
+
+ No new tests, existing webaudio tests cover this change.
+
+ * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+ (webKitWebAudioSrcConstructed):
+ (webKitWebAudioSrcChangeState):
+
2020-04-23 Sergio Villar Senin <[email protected]>
[WebXR][WPE] Implement XRTest::simulateDeviceConnection()
Modified: trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (260885 => 260886)
--- trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-04-29 07:59:17 UTC (rev 260885)
+++ trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-04-29 08:14:06 UTC (rev 260886)
@@ -211,10 +211,10 @@
ASSERT(priv->provider);
ASSERT(priv->sampleRate);
- priv->interleave = gst_element_factory_make("interleave", nullptr);
+ priv->interleave = gst_element_factory_make("audiointerleave", nullptr);
if (!priv->interleave) {
- GST_ERROR_OBJECT(src, "Failed to create interleave");
+ GST_ERROR_OBJECT(src, "Failed to create audiointerleave");
return;
}
@@ -398,8 +398,8 @@
switch (transition) {
case GST_STATE_CHANGE_NULL_TO_READY:
if (!src->priv->interleave) {
- gst_element_post_message(element, gst_missing_element_message_new(element, "interleave"));
- GST_ELEMENT_ERROR(src, CORE, MISSING_PLUGIN, (nullptr), ("no interleave"));
+ gst_element_post_message(element, gst_missing_element_message_new(element, "audiointerleave"));
+ GST_ELEMENT_ERROR(src, CORE, MISSING_PLUGIN, (nullptr), ("no audiointerleave"));
return GST_STATE_CHANGE_FAILURE;
}
src->priv->numberOfSamples = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
