Title: [260921] trunk/Source/WebCore
Revision
260921
Author
[email protected]
Date
2020-04-29 15:45:31 -0700 (Wed, 29 Apr 2020)

Log Message

Remove the debug ASSERT in ImageDecoderAVFObjC::storeSampleBuffer()
https://bugs.webkit.org/show_bug.cgi?id=211191
<rdar://problem/62542285>

Reviewed by Said Abou-Hallawa.

r259594 added an iterator check and a RELEASE_LOG_ERROR for that check, making this ASSERT superfluous.

* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (260920 => 260921)


--- trunk/Source/WebCore/ChangeLog	2020-04-29 22:37:15 UTC (rev 260920)
+++ trunk/Source/WebCore/ChangeLog	2020-04-29 22:45:31 UTC (rev 260921)
@@ -1,3 +1,16 @@
+2020-04-29  Jer Noble  <[email protected]>
+
+        Remove the debug ASSERT in ImageDecoderAVFObjC::storeSampleBuffer()
+        https://bugs.webkit.org/show_bug.cgi?id=211191
+        <rdar://problem/62542285>
+
+        Reviewed by Said Abou-Hallawa.
+
+        r259594 added an iterator check and a RELEASE_LOG_ERROR for that check, making this ASSERT superfluous.
+
+        * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+        (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):
+
 2020-04-29  Simon Fraser  <[email protected]>
 
         Simplify contents clipping layer geometry

Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm (260920 => 260921)


--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm	2020-04-29 22:37:15 UTC (rev 260920)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm	2020-04-29 22:45:31 UTC (rev 260921)
@@ -437,7 +437,6 @@
         return false;
     }
 
-    ASSERT(iter != m_sampleData.presentationOrder().end());
     if (iter == m_sampleData.presentationOrder().end()) {
         RELEASE_LOG_ERROR(Images, "ImageDecoderAVFObjC::storeSampleBuffer(%p) - could not find sample buffer entry with specified presentation time", this);
         return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to